[libc-commits] [libc] [libc] Mark internal __llvm_libc_errno as noexcept (PR #98760)

Sat Jul 13 11:31:00 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/104/builds/2088

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[19/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.roundf16_test.__unit__.__build__.dir/roundf16_test.cpp.o
[20/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.copysign_test.__unit__.__build__.dir/copysign_test.cpp.o
[21/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.rintf16_test.__unit__.__build__.dir/rintf16_test.cpp.o
[22/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.llrintl_test.__unit__.__build__.dir/llrintl_test.cpp.o
[23/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.llrintf16_test.__unit__.__build__.dir/llrintf16_test.cpp.o
[24/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.expm1_test.__unit__.__build__.dir/expm1_test.cpp.o
[25/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.coshf_test.__unit__.__build__.dir/coshf_test.cpp.o
[26/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.ceill_test.__unit__.__build__.dir/ceill_test.cpp.o
[27/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.fmul_test.__unit__.__build__.dir/fmul_test.cpp.o
[28/2366] Building CXX object projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o
FAILED: projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_18_0_0_git -D_DEBUG -Iprojects/libc/src/errno -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/errno -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -std=c++17 -MD -MT projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o -MF projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o.d -o projects/libc/src/errno/CMakeFiles/libc.src.errno.errno.__internal__.dir/libc_errno.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/errno/libc_errno.cpp
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/errno/libc_errno.cpp:60:17: error: '__llvm_libc_errno' is missing exception specification 'noexcept'
extern "C" int *__llvm_libc_errno() { return &thread_errno; }
                ^
                                    noexcept
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/errno/libc_errno.h:36:17: note: previous declaration is here
extern "C" int *__llvm_libc_errno() noexcept;
                ^
1 error generated.
[29/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.nextdown_test.__unit__.__build__.dir/nextdown_test.cpp.o
[30/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.copysignf16_test.__unit__.__build__.dir/copysignf16_test.cpp.o
[31/2366] Building CXX object projects/libc/test/src/math/CMakeFiles/libc.test.src.math.llroundf16_test.__unit__.__build__.dir/llroundf16_test.cpp.o
[32/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.copysignl_test.__unit__.__build__.dir/copysignl_test.cpp.o
[33/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.exp10f_test.__unit__.__build__.dir/exp10f_test.cpp.o
[34/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.roundf16_test.__unit__.__build__.dir/roundf16_test.cpp.o
[35/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.copysign_test.__unit__.__build__.dir/copysign_test.cpp.o
[36/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.llroundf16_test.__unit__.__build__.dir/llroundf16_test.cpp.o
[37/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.llrintf16_test.__unit__.__build__.dir/llrintf16_test.cpp.o
[38/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.llrintl_test.__unit__.__build__.dir/llrintl_test.cpp.o
[39/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.f16sub_test.__unit__.__build__.dir/f16sub_test.cpp.o
[40/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.exp2_test.__unit__.__build__.dir/exp2_test.cpp.o
[41/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.llrintf128_test.__unit__.__build__.dir/llrintf128_test.cpp.o
[42/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.sqrtf128_test.__unit__.__build__.dir/sqrtf128_test.cpp.o
[43/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.llrint_test.__unit__.__build__.dir/llrint_test.cpp.o
[44/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.nearbyintf_test.__unit__.__build__.dir/nearbyintf_test.cpp.o
[45/2366] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.floorf_test.__unit__.__build__.dir/floorf_test.cpp.o
ninja: build stopped: subcommand failed.
['ninja', 'libc-unit-tests'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 164, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 132, in main
    run_command(['ninja', 'libc-unit-tests'])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 179, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
    subprocess.check_call(cmd, shell=shell, *args, **kwargs)

```

https://github.com/llvm/llvm-project/pull/98760