[libc-commits] [libc] [libc] Remove src/errno/errno.h (PR #98759)

Sat Jul 13 11:25:14 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-fullbuild-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/2076

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[       OK ] LlvmLibcCharVectorTest.AppendLong (125 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[20/2382] Linking CXX executable projects/libc/test/src/__support/libc.test.src.__support.integer_to_string_test.__unit__.__build__
[21/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetround.dir/fesetround.cpp.o
[22/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feclearexcept.dir/feclearexcept.cpp.o
[23/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexceptflag.dir/fetestexceptflag.cpp.o
[24/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexceptflag.dir/fegetexceptflag.cpp.o
[25/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexceptflag.__internal__.dir/fesetexceptflag.cpp.o
[26/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexcept.__internal__.dir/fesetexcept.cpp.o
[27/2382] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o
FAILED: projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -mcpu=native -std=c++17 -MD -MT projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o -MF projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o.d -o projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/lroundl_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/lroundl_test.cpp:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/RoundToIntegerTest.h:20:
projects/libc/include/errno.h:30:6: error: exception specification in declaration does not match previous declaration
int *__llvm_libc_errno(void) __NOEXCEPT;
     ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/src/errno/libc_errno.h:36:17: note: previous declaration is here
extern "C" int *__llvm_libc_errno();
                ^
1 error generated.
[28/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexceptflag.dir/fesetexceptflag.cpp.o
[29/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feholdexcept.dir/feholdexcept.cpp.o
[30/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feupdateenv.dir/feupdateenv.cpp.o
[31/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexcept.dir/fesetexcept.cpp.o
[32/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexceptflag.__internal__.dir/fegetexceptflag.cpp.o
[33/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feenableexcept.__internal__.dir/feenableexcept.cpp.o
[34/2382] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.copysignf_test.__unit__.__build__.dir/copysignf_test.cpp.o
[35/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fedisableexcept.dir/fedisableexcept.cpp.o
[36/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fedisableexcept.__internal__.dir/fedisableexcept.cpp.o
[37/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetenv.__internal__.dir/fegetenv.cpp.o
[38/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexcept.dir/fetestexcept.cpp.o
[39/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexcept.__internal__.dir/fegetexcept.cpp.o
[40/2382] Building CXX object projects/libc/test/src/__support/CMakeFiles/libc.test.src.__support.high_precision_decimal_test.__unit__.__build__.dir/high_precision_decimal_test.cpp.o
[41/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexcept.__internal__.dir/fetestexcept.cpp.o
[42/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feenableexcept.dir/feenableexcept.cpp.o
[43/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feupdateenv.__internal__.dir/feupdateenv.cpp.o
[44/2382] Building CXX object projects/libc/test/src/__support/CMakeFiles/libc.test.src.__support.str_to_integer_test.__unit__.__build__.dir/str_to_integer_test.cpp.o
ninja: build stopped: subcommand failed.
['ninja', 'libc-unit-tests'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 164, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 132, in main
    run_command(['ninja', 'libc-unit-tests'])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 179, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd
Step 8 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[       OK ] LlvmLibcCharVectorTest.AppendLong (125 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[20/2382] Linking CXX executable projects/libc/test/src/__support/libc.test.src.__support.integer_to_string_test.__unit__.__build__
[21/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetround.dir/fesetround.cpp.o
[22/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feclearexcept.dir/feclearexcept.cpp.o
[23/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexceptflag.dir/fetestexceptflag.cpp.o
[24/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexceptflag.dir/fegetexceptflag.cpp.o
[25/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexceptflag.__internal__.dir/fesetexceptflag.cpp.o
[26/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexcept.__internal__.dir/fesetexcept.cpp.o
[27/2382] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o
FAILED: projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -mcpu=native -std=c++17 -MD -MT projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o -MF projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o.d -o projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.lroundl_test.__unit__.__build__.dir/lroundl_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/lroundl_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/lroundl_test.cpp:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/RoundToIntegerTest.h:20:
projects/libc/include/errno.h:30:6: error: exception specification in declaration does not match previous declaration
int *__llvm_libc_errno(void) __NOEXCEPT;
     ^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/src/errno/libc_errno.h:36:17: note: previous declaration is here
extern "C" int *__llvm_libc_errno();
                ^
1 error generated.
[28/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexceptflag.dir/fesetexceptflag.cpp.o
[29/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feholdexcept.dir/feholdexcept.cpp.o
[30/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feupdateenv.dir/feupdateenv.cpp.o
[31/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fesetexcept.dir/fesetexcept.cpp.o
[32/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexceptflag.__internal__.dir/fegetexceptflag.cpp.o
[33/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feenableexcept.__internal__.dir/feenableexcept.cpp.o
[34/2382] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.copysignf_test.__unit__.__build__.dir/copysignf_test.cpp.o
[35/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fedisableexcept.dir/fedisableexcept.cpp.o
[36/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fedisableexcept.__internal__.dir/fedisableexcept.cpp.o
[37/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetenv.__internal__.dir/fegetenv.cpp.o
[38/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexcept.dir/fetestexcept.cpp.o
[39/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fegetexcept.__internal__.dir/fegetexcept.cpp.o
[40/2382] Building CXX object projects/libc/test/src/__support/CMakeFiles/libc.test.src.__support.high_precision_decimal_test.__unit__.__build__.dir/high_precision_decimal_test.cpp.o
[41/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.fetestexcept.__internal__.dir/fetestexcept.cpp.o
[42/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feenableexcept.dir/feenableexcept.cpp.o
[43/2382] Building CXX object projects/libc/src/fenv/CMakeFiles/libc.src.fenv.feupdateenv.__internal__.dir/feupdateenv.cpp.o
[44/2382] Building CXX object projects/libc/test/src/__support/CMakeFiles/libc.test.src.__support.str_to_integer_test.__unit__.__build__.dir/str_to_integer_test.cpp.o
ninja: build stopped: subcommand failed.
['ninja', 'libc-unit-tests'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 164, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 132, in main
    run_command(['ninja', 'libc-unit-tests'])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 179, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd

```

https://github.com/llvm/llvm-project/pull/98759