[libc-commits] [libc] [libc] Fix warnings emitted by GCC (PR #98751)
via libc-commits
libc-commits at lists.llvm.org
Sat Jul 13 09:10:27 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: OverMighty (overmighty)
<details>
<summary>Changes</summary>
Fixes #<!-- -->98709.
---
Patch is 42.25 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/98751.diff
18 Files Affected:
- (modified) libc/test/src/__support/FPUtil/fpbits_test.cpp (+1)
- (modified) libc/test/src/__support/big_int_test.cpp (+6-1)
- (modified) libc/test/src/math/RoundToIntegerTest.h (+3-1)
- (modified) libc/test/src/math/smoke/FMaxTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FMaximumMagNumTest.h (+12-12)
- (modified) libc/test/src/math/smoke/FMaximumMagTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FMaximumNumTest.h (+12-12)
- (modified) libc/test/src/math/smoke/FMaximumTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FMinTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FMinimumMagNumTest.h (+12-12)
- (modified) libc/test/src/math/smoke/FMinimumMagTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FMinimumNumTest.h (+12-12)
- (modified) libc/test/src/math/smoke/FMinimumTest.h (+10-10)
- (modified) libc/test/src/math/smoke/FModTest.h (+85-85)
- (modified) libc/test/src/math/smoke/FrexpTest.h (+2-2)
- (modified) libc/test/src/math/smoke/ILogbTest.h (+8-8)
- (modified) libc/test/src/math/smoke/LogbTest.h (+2-2)
- (modified) libc/test/src/stdio/sprintf_test.cpp (+3-4)
``````````diff
diff --git a/libc/test/src/__support/FPUtil/fpbits_test.cpp b/libc/test/src/__support/FPUtil/fpbits_test.cpp
index af20b1a0bdc7e..99acc03010344 100644
--- a/libc/test/src/__support/FPUtil/fpbits_test.cpp
+++ b/libc/test/src/__support/FPUtil/fpbits_test.cpp
@@ -238,6 +238,7 @@ template <typename T> constexpr auto make(Sign sign, FP fp) {
case FP::QUIET_NAN:
return T::quiet_nan(sign);
}
+ __builtin_unreachable();
}
// Tests all properties for all types of float.
diff --git a/libc/test/src/__support/big_int_test.cpp b/libc/test/src/__support/big_int_test.cpp
index 2c3d57755cd5b..a1ce69baaae29 100644
--- a/libc/test/src/__support/big_int_test.cpp
+++ b/libc/test/src/__support/big_int_test.cpp
@@ -32,6 +32,7 @@ template <typename T> auto create(Value value) {
case MAX:
return T::max();
}
+ __builtin_unreachable();
}
using Types = testing::TypeList< //
@@ -264,7 +265,11 @@ TEST(LlvmLibcUIntClassTest, BitCastToFromNativeFloat128) {
TEST(LlvmLibcUIntClassTest, BitCastToFromNativeFloat16) {
static_assert(cpp::is_trivially_copyable<LL_UInt16>::value);
static_assert(sizeof(LL_UInt16) == sizeof(float16));
- const float16 array[] = {0, 0.1, 1};
+ const float16 array[] = {
+ static_cast<float16>(0.0),
+ static_cast<float16>(0.1),
+ static_cast<float16>(1.0),
+ };
for (float16 value : array) {
LL_UInt16 back = cpp::bit_cast<LL_UInt16>(value);
float16 forth = cpp::bit_cast<float16>(back);
diff --git a/libc/test/src/math/RoundToIntegerTest.h b/libc/test/src/math/RoundToIntegerTest.h
index 2b1c643267590..d3e557a847953 100644
--- a/libc/test/src/math/RoundToIntegerTest.h
+++ b/libc/test/src/math/RoundToIntegerTest.h
@@ -167,7 +167,9 @@ class RoundToIntegerTestTemplate
}
void do_fractions_test(RoundToIntegerFunc func, int mode) {
- constexpr F FRACTIONS[] = {0.5, -0.5, 0.115, -0.115, 0.715, -0.715};
+ constexpr F FRACTIONS[] = {
+ F(0.5), F(-0.5), F(0.115), F(-0.115), F(0.715), F(-0.715),
+ };
for (F x : FRACTIONS) {
long mpfr_long_result;
bool erangeflag;
diff --git a/libc/test/src/math/smoke/FMaxTest.h b/libc/test/src/math/smoke/FMaxTest.h
index f4c78b5d04b5b..1cb105aa00778 100644
--- a/libc/test/src/math/smoke/FMaxTest.h
+++ b/libc/test/src/math/smoke/FMaxTest.h
@@ -25,8 +25,8 @@ class FMaxTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testNaN(FMaxFunc func) {
EXPECT_FP_EQ(inf, func(aNaN, inf));
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
- EXPECT_FP_EQ(0.0, func(aNaN, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, aNaN));
+ EXPECT_FP_EQ(zero, func(aNaN, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, aNaN));
EXPECT_FP_EQ(T(-1.2345), func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, aNaN));
@@ -34,25 +34,25 @@ class FMaxTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMaxFunc func) {
EXPECT_FP_EQ(inf, func(neg_inf, inf));
- EXPECT_FP_EQ(inf, func(inf, 0.0));
- EXPECT_FP_EQ(inf, func(-0.0, inf));
+ EXPECT_FP_EQ(inf, func(inf, zero));
+ EXPECT_FP_EQ(inf, func(neg_zero, inf));
EXPECT_FP_EQ(inf, func(inf, T(1.2345)));
EXPECT_FP_EQ(inf, func(T(-1.2345), inf));
}
void testNegInfArg(FMaxFunc func) {
EXPECT_FP_EQ(inf, func(inf, neg_inf));
- EXPECT_FP_EQ(0.0, func(neg_inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(zero, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_inf));
EXPECT_FP_EQ(T(-1.2345), func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), neg_inf));
}
void testBothZero(FMaxFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMaxFunc func) {
diff --git a/libc/test/src/math/smoke/FMaximumMagNumTest.h b/libc/test/src/math/smoke/FMaximumMagNumTest.h
index 726f87059fc64..b52169e5e8680 100644
--- a/libc/test/src/math/smoke/FMaximumMagNumTest.h
+++ b/libc/test/src/math/smoke/FMaximumMagNumTest.h
@@ -30,10 +30,10 @@ class FMaximumMagNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(neg_inf, func(neg_inf, sNaN), FE_INVALID);
EXPECT_EQ(FPBits(aNaN).uintval(), FPBits(func(aNaN, aNaN)).uintval());
- EXPECT_FP_EQ(0.0, func(aNaN, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, aNaN));
- EXPECT_FP_EQ_WITH_EXCEPTION(0.0, func(sNaN, 0.0), FE_INVALID);
- EXPECT_FP_EQ_WITH_EXCEPTION(-0.0, func(-0.0, sNaN), FE_INVALID);
+ EXPECT_FP_EQ(zero, func(aNaN, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, aNaN));
+ EXPECT_FP_EQ_WITH_EXCEPTION(zero, func(sNaN, zero), FE_INVALID);
+ EXPECT_FP_EQ_WITH_EXCEPTION(neg_zero, func(neg_zero, sNaN), FE_INVALID);
EXPECT_FP_EQ(T(-1.2345), func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(T(-1.2345), func(sNaN, T(-1.2345)), FE_INVALID);
@@ -47,25 +47,25 @@ class FMaximumMagNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMaximumMagNumFunc func) {
EXPECT_FP_EQ(inf, func(neg_inf, inf));
- EXPECT_FP_EQ(inf, func(inf, 0.0));
- EXPECT_FP_EQ(inf, func(-0.0, inf));
+ EXPECT_FP_EQ(inf, func(inf, zero));
+ EXPECT_FP_EQ(inf, func(neg_zero, inf));
EXPECT_FP_EQ(inf, func(inf, T(1.2345)));
EXPECT_FP_EQ(inf, func(T(-1.2345), inf));
}
void testNegInfArg(FMaximumMagNumFunc func) {
EXPECT_FP_EQ(inf, func(inf, neg_inf));
- EXPECT_FP_EQ(neg_inf, func(neg_inf, 0.0));
- EXPECT_FP_EQ(neg_inf, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(neg_inf, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_inf, func(neg_zero, neg_inf));
EXPECT_FP_EQ(neg_inf, func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(neg_inf, func(T(1.2345), neg_inf));
}
void testBothZero(FMaximumMagNumFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMaximumMagNumFunc func) {
diff --git a/libc/test/src/math/smoke/FMaximumMagTest.h b/libc/test/src/math/smoke/FMaximumMagTest.h
index b5b2c1ca79abc..81a232d96ec94 100644
--- a/libc/test/src/math/smoke/FMaximumMagTest.h
+++ b/libc/test/src/math/smoke/FMaximumMagTest.h
@@ -26,8 +26,8 @@ class FMaximumMagTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testNaN(FMaximumMagFunc func) {
EXPECT_FP_EQ(aNaN, func(aNaN, inf));
EXPECT_FP_EQ(aNaN, func(neg_inf, aNaN));
- EXPECT_FP_EQ(aNaN, func(aNaN, 0.0));
- EXPECT_FP_EQ(aNaN, func(-0.0, aNaN));
+ EXPECT_FP_EQ(aNaN, func(aNaN, zero));
+ EXPECT_FP_EQ(aNaN, func(neg_zero, aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(aNaN, func(T(1.2345), aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, aNaN));
@@ -35,25 +35,25 @@ class FMaximumMagTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMaximumMagFunc func) {
EXPECT_FP_EQ(inf, func(neg_inf, inf));
- EXPECT_FP_EQ(inf, func(inf, 0.0));
- EXPECT_FP_EQ(inf, func(-0.0, inf));
+ EXPECT_FP_EQ(inf, func(inf, zero));
+ EXPECT_FP_EQ(inf, func(neg_zero, inf));
EXPECT_FP_EQ(inf, func(inf, T(1.2345)));
EXPECT_FP_EQ(inf, func(T(-1.2345), inf));
}
void testNegInfArg(FMaximumMagFunc func) {
EXPECT_FP_EQ(inf, func(inf, neg_inf));
- EXPECT_FP_EQ(neg_inf, func(neg_inf, 0.0));
- EXPECT_FP_EQ(neg_inf, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(neg_inf, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_inf, func(neg_zero, neg_inf));
EXPECT_FP_EQ(neg_inf, func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(neg_inf, func(T(1.2345), neg_inf));
}
void testBothZero(FMaximumMagFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMaximumMagFunc func) {
diff --git a/libc/test/src/math/smoke/FMaximumNumTest.h b/libc/test/src/math/smoke/FMaximumNumTest.h
index ec7913509d394..f4e05b9f455ed 100644
--- a/libc/test/src/math/smoke/FMaximumNumTest.h
+++ b/libc/test/src/math/smoke/FMaximumNumTest.h
@@ -29,10 +29,10 @@ class FMaximumNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(neg_inf, func(neg_inf, sNaN), FE_INVALID);
EXPECT_EQ(FPBits(aNaN).uintval(), FPBits(func(aNaN, aNaN)).uintval());
- EXPECT_FP_EQ(0.0, func(aNaN, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, aNaN));
- EXPECT_FP_EQ_WITH_EXCEPTION(0.0, func(sNaN, 0.0), FE_INVALID);
- EXPECT_FP_EQ_WITH_EXCEPTION(-0.0, func(-0.0, sNaN), FE_INVALID);
+ EXPECT_FP_EQ(zero, func(aNaN, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, aNaN));
+ EXPECT_FP_EQ_WITH_EXCEPTION(zero, func(sNaN, zero), FE_INVALID);
+ EXPECT_FP_EQ_WITH_EXCEPTION(neg_zero, func(neg_zero, sNaN), FE_INVALID);
EXPECT_FP_EQ(T(-1.2345), func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(T(-1.2345), func(sNaN, T(-1.2345)), FE_INVALID);
@@ -46,25 +46,25 @@ class FMaximumNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMaximumNumFunc func) {
EXPECT_FP_EQ(inf, func(neg_inf, inf));
- EXPECT_FP_EQ(inf, func(inf, 0.0));
- EXPECT_FP_EQ(inf, func(-0.0, inf));
+ EXPECT_FP_EQ(inf, func(inf, zero));
+ EXPECT_FP_EQ(inf, func(neg_zero, inf));
EXPECT_FP_EQ(inf, func(inf, T(1.2345)));
EXPECT_FP_EQ(inf, func(T(-1.2345), inf));
}
void testNegInfArg(FMaximumNumFunc func) {
EXPECT_FP_EQ(inf, func(inf, neg_inf));
- EXPECT_FP_EQ(0.0, func(neg_inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(zero, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_inf));
EXPECT_FP_EQ(T(-1.2345), func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), neg_inf));
}
void testBothZero(FMaximumNumFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMaximumNumFunc func) {
diff --git a/libc/test/src/math/smoke/FMaximumTest.h b/libc/test/src/math/smoke/FMaximumTest.h
index 94e4a343190a5..5e71a41d7b345 100644
--- a/libc/test/src/math/smoke/FMaximumTest.h
+++ b/libc/test/src/math/smoke/FMaximumTest.h
@@ -25,8 +25,8 @@ class FMaximumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testNaN(FMaximumFunc func) {
EXPECT_FP_EQ(aNaN, func(aNaN, inf));
EXPECT_FP_EQ(aNaN, func(neg_inf, aNaN));
- EXPECT_FP_EQ(aNaN, func(aNaN, 0.0));
- EXPECT_FP_EQ(aNaN, func(-0.0, aNaN));
+ EXPECT_FP_EQ(aNaN, func(aNaN, zero));
+ EXPECT_FP_EQ(aNaN, func(neg_zero, aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(aNaN, func(T(1.2345), aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, aNaN));
@@ -34,25 +34,25 @@ class FMaximumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMaximumFunc func) {
EXPECT_FP_EQ(inf, func(neg_inf, inf));
- EXPECT_FP_EQ(inf, func(inf, 0.0));
- EXPECT_FP_EQ(inf, func(-0.0, inf));
+ EXPECT_FP_EQ(inf, func(inf, zero));
+ EXPECT_FP_EQ(inf, func(neg_zero, inf));
EXPECT_FP_EQ(inf, func(inf, T(1.2345)));
EXPECT_FP_EQ(inf, func(T(-1.2345), inf));
}
void testNegInfArg(FMaximumFunc func) {
EXPECT_FP_EQ(inf, func(inf, neg_inf));
- EXPECT_FP_EQ(0.0, func(neg_inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(zero, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_inf));
EXPECT_FP_EQ(T(-1.2345), func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), neg_inf));
}
void testBothZero(FMaximumFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMaximumFunc func) {
diff --git a/libc/test/src/math/smoke/FMinTest.h b/libc/test/src/math/smoke/FMinTest.h
index 629aaab729a86..049d94eb1b340 100644
--- a/libc/test/src/math/smoke/FMinTest.h
+++ b/libc/test/src/math/smoke/FMinTest.h
@@ -25,8 +25,8 @@ class FMinTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testNaN(FMinFunc func) {
EXPECT_FP_EQ(inf, func(aNaN, inf));
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
- EXPECT_FP_EQ(0.0, func(aNaN, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, aNaN));
+ EXPECT_FP_EQ(zero, func(aNaN, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, aNaN));
EXPECT_FP_EQ(T(-1.2345), func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, aNaN));
@@ -34,25 +34,25 @@ class FMinTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMinFunc func) {
EXPECT_FP_EQ(neg_inf, func(neg_inf, inf));
- EXPECT_FP_EQ(0.0, func(inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, inf));
+ EXPECT_FP_EQ(zero, func(inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, inf));
EXPECT_FP_EQ(T(1.2345), func(inf, T(1.2345)));
EXPECT_FP_EQ(T(-1.2345), func(T(-1.2345), inf));
}
void testNegInfArg(FMinFunc func) {
EXPECT_FP_EQ(neg_inf, func(inf, neg_inf));
- EXPECT_FP_EQ(neg_inf, func(neg_inf, 0.0));
- EXPECT_FP_EQ(neg_inf, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(neg_inf, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_inf, func(neg_zero, neg_inf));
EXPECT_FP_EQ(neg_inf, func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(neg_inf, func(T(1.2345), neg_inf));
}
void testBothZero(FMinFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMinFunc func) {
diff --git a/libc/test/src/math/smoke/FMinimumMagNumTest.h b/libc/test/src/math/smoke/FMinimumMagNumTest.h
index 2ceca6ff95bac..4cec6f08b2daa 100644
--- a/libc/test/src/math/smoke/FMinimumMagNumTest.h
+++ b/libc/test/src/math/smoke/FMinimumMagNumTest.h
@@ -30,10 +30,10 @@ class FMinimumMagNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(neg_inf, func(neg_inf, sNaN), FE_INVALID);
EXPECT_EQ(FPBits(aNaN).uintval(), FPBits(func(aNaN, aNaN)).uintval());
- EXPECT_FP_EQ(0.0, func(aNaN, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, aNaN));
- EXPECT_FP_EQ_WITH_EXCEPTION(0.0, func(sNaN, 0.0), FE_INVALID);
- EXPECT_FP_EQ_WITH_EXCEPTION(-0.0, func(-0.0, sNaN), FE_INVALID);
+ EXPECT_FP_EQ(zero, func(aNaN, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, aNaN));
+ EXPECT_FP_EQ_WITH_EXCEPTION(zero, func(sNaN, zero), FE_INVALID);
+ EXPECT_FP_EQ_WITH_EXCEPTION(neg_zero, func(neg_zero, sNaN), FE_INVALID);
EXPECT_FP_EQ(T(-1.2345), func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(T(-1.2345), func(sNaN, T(-1.2345)), FE_INVALID);
@@ -47,25 +47,25 @@ class FMinimumMagNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMinimumMagNumFunc func) {
EXPECT_FP_EQ(neg_inf, func(neg_inf, inf));
- EXPECT_FP_EQ(0.0, func(inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, inf));
+ EXPECT_FP_EQ(zero, func(inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, inf));
EXPECT_FP_EQ(T(1.2345), func(inf, T(1.2345)));
EXPECT_FP_EQ(T(-1.2345), func(T(-1.2345), inf));
}
void testNegInfArg(FMinimumMagNumFunc func) {
EXPECT_FP_EQ(neg_inf, func(inf, neg_inf));
- EXPECT_FP_EQ(0.0, func(neg_inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(zero, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_inf));
EXPECT_FP_EQ(T(-1.2345), func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), neg_inf));
}
void testBothZero(FMinimumMagNumFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMinimumMagNumFunc func) {
diff --git a/libc/test/src/math/smoke/FMinimumMagTest.h b/libc/test/src/math/smoke/FMinimumMagTest.h
index 9c49446795cee..18b43815bdeca 100644
--- a/libc/test/src/math/smoke/FMinimumMagTest.h
+++ b/libc/test/src/math/smoke/FMinimumMagTest.h
@@ -26,8 +26,8 @@ class FMinimumMagTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testNaN(FMinimumMagFunc func) {
EXPECT_FP_EQ(aNaN, func(aNaN, inf));
EXPECT_FP_EQ(aNaN, func(neg_inf, aNaN));
- EXPECT_FP_EQ(aNaN, func(aNaN, 0.0));
- EXPECT_FP_EQ(aNaN, func(-0.0, aNaN));
+ EXPECT_FP_EQ(aNaN, func(aNaN, zero));
+ EXPECT_FP_EQ(aNaN, func(neg_zero, aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, T(-1.2345)));
EXPECT_FP_EQ(aNaN, func(T(1.2345), aNaN));
EXPECT_FP_EQ(aNaN, func(aNaN, aNaN));
@@ -35,25 +35,25 @@ class FMinimumMagTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
void testInfArg(FMinimumMagFunc func) {
EXPECT_FP_EQ(neg_inf, func(neg_inf, inf));
- EXPECT_FP_EQ(0.0, func(inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, inf));
+ EXPECT_FP_EQ(zero, func(inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, inf));
EXPECT_FP_EQ(T(1.2345), func(inf, T(1.2345)));
EXPECT_FP_EQ(T(-1.2345), func(T(-1.2345), inf));
}
void testNegInfArg(FMinimumMagFunc func) {
EXPECT_FP_EQ(neg_inf, func(inf, neg_inf));
- EXPECT_FP_EQ(0.0, func(neg_inf, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, neg_inf));
+ EXPECT_FP_EQ(zero, func(neg_inf, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_inf));
EXPECT_FP_EQ(T(-1.2345), func(neg_inf, T(-1.2345)));
EXPECT_FP_EQ(T(1.2345), func(T(1.2345), neg_inf));
}
void testBothZero(FMinimumMagFunc func) {
- EXPECT_FP_EQ(0.0, func(0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, 0.0));
- EXPECT_FP_EQ(-0.0, func(0.0, -0.0));
- EXPECT_FP_EQ(-0.0, func(-0.0, -0.0));
+ EXPECT_FP_EQ(zero, func(zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, zero));
+ EXPECT_FP_EQ(neg_zero, func(zero, neg_zero));
+ EXPECT_FP_EQ(neg_zero, func(neg_zero, neg_zero));
}
void testRange(FMinimumMagFunc func) {
diff --git a/libc/test/src/math/smoke/FMinimumNumTest.h b/libc/test/src/math/smoke/FMinimumNumTest.h
index 8004ee9874543..dddcdc28d30c8 100644
--- a/libc/test/src/math/smoke/FMinimumNumTest.h
+++ b/libc/test/src/math/smoke/FMinimumNumTest.h
@@ -29,10 +29,10 @@ class FMinimumNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_FP_EQ(neg_inf, func(neg_inf, aNaN));
EXPECT_FP_EQ_WITH_EXCEPTION(neg_inf, func(neg_inf, sNaN), FE_INVALID);
EXPECT_EQ(FPBits(aNaN).uintval(), FPBits(func(aNaN, aNaN)).uintval());
- EXPECT_FP...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/98751
More information about the libc-commits
mailing list