[libc-commits] [libc] [libc] Change rand implementation so all tests pass in both 32- and 64-bit systems (PR #98692)

[Mikhail R. Gadelha via libc-commits]

mikhailramalho wrote:

I've tried, and a static_cast back to unsigned long on compare exchange
call, but the fsb test still failed

On Fri, 12 Jul 2024, 17:49 Joseph Huber, ***@***.***> wrote:

> ***@***.**** commented on this pull request.
>
> If we change x to uint64_t wouldn't that also solve the issue? It's
> called xorshift64star because it needs 64-bit state, but I forgot that unsigned
> long was 32-bit on some systems.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/98692#pullrequestreview-2175724880>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAKEJHZ45JOGB6OW3ICRTNLZMA6MDAVCNFSM6AAAAABKZRQQ6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZVG4ZDIOBYGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/98692