[libc-commits] [libc] [libc] newheadergen: quick fixes to tests (PR #98561)

via libc-commits libc-commits at lists.llvm.org
Thu Jul 11 15:19:18 PDT 2024


https://github.com/aaryanshukla created https://github.com/llvm/llvm-project/pull/98561

- if there is an object made there is a space after
- fixed tests.yaml -- spacing between characters issue


>From 054bef307cf709a37a8e5d882a9fe62ff6c30240 Mon Sep 17 00:00:00 2001
From: Aaryan Shukla <aaryanshukla at google.com>
Date: Thu, 11 Jul 2024 22:16:42 +0000
Subject: [PATCH] [libc] newheadergen: quick fixes to tests

- if there is an object made there is a space after
- fixed tests.yaml -- spacing between characters issue
---
 libc/newhdrgen/header.py                           | 5 ++++-
 libc/newhdrgen/tests/expected_output/test_header.h | 4 ++--
 libc/newhdrgen/tests/input/test_small.yaml         | 6 ++++--
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/libc/newhdrgen/header.py b/libc/newhdrgen/header.py
index d9e9c68dfc5f4..ca960b639ab10 100644
--- a/libc/newhdrgen/header.py
+++ b/libc/newhdrgen/header.py
@@ -62,6 +62,9 @@ def __str__(self):
             content.append("")
         for object in self.objects:
             content.append(str(object))
-        content.append("__END_C_DECLS")
+        if self.objects:
+            content.append("\n__END_C_DECLS")
+        else:
+            content.append("__END_C_DECLS")
 
         return "\n".join(content)
diff --git a/libc/newhdrgen/tests/expected_output/test_header.h b/libc/newhdrgen/tests/expected_output/test_header.h
index d6ae0d0e282e7..02ca8ecf196ed 100644
--- a/libc/newhdrgen/tests/expected_output/test_header.h
+++ b/libc/newhdrgen/tests/expected_output/test_header.h
@@ -27,11 +27,11 @@ enum {
 __BEGIN_C_DECLS
 
 #ifdef FUNC_A_16
-void func_a()CONST_FUNC_A;
+CONST_FUNC_A void func_a() __NOEXCEPT;
 #endif // FUNC_A_16
 
 #ifdef FUNC_B_16
-int func_b(int, float)CONST_FUNC_B;
+CONST_FUNC_B int func_b(int, float) __NOEXCEPT;
 #endif // FUNC_B_16
 
 extern obj object_1;
diff --git a/libc/newhdrgen/tests/input/test_small.yaml b/libc/newhdrgen/tests/input/test_small.yaml
index 0bc292db72396..7d657d9ecad5f 100644
--- a/libc/newhdrgen/tests/input/test_small.yaml
+++ b/libc/newhdrgen/tests/input/test_small.yaml
@@ -24,7 +24,8 @@ functions:
     standards: 
       - stdc
     guard: FUNC_A_16
-    attributes: CONST_FUNC_A
+    attributes: 
+      - CONST_FUNC_A
   - name: func_b
     return_type: int
     arguments:
@@ -33,4 +34,5 @@ functions:
     standards: 
       - stdc
     guard: FUNC_B_16
-    attributes: CONST_FUNC_B
+    attributes: 
+      - CONST_FUNC_B



More information about the libc-commits mailing list