[libc-commits] [libc] [libc] Fix readlink tests on 32-bit systems (PR #98168)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Tue Jul 9 12:44:08 PDT 2024


================
@@ -40,7 +42,8 @@ TEST(LlvmLibcReadlinkTest, CreateAndUnlink) {
 
 TEST(LlvmLibcReadlinkTest, ReadlinkInNonExistentPath) {
   using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;
-  char buf[8];
-  ASSERT_THAT(LIBC_NAMESPACE::readlink("non-existent-link", buf, sizeof(buf)),
+  constexpr auto len = 8;
----------------
michaelrj-google wrote:

nit: constexpr variables like this should have their names in caps, i.e. `LEN`

https://github.com/llvm/llvm-project/pull/98168


More information about the libc-commits mailing list