[libc-commits] [libc] [libc] Fix sprintf FixedConv test (PR #98204)
via libc-commits
libc-commits at lists.llvm.org
Tue Jul 9 12:28:59 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Mikhail R. Gadelha (mikhailramalho)
<details>
<summary>Changes</summary>
Similar to #<!-- -->98195.
This patch enlarges the number to ensure that a 64-bit number is being read.
---
Full diff: https://github.com/llvm/llvm-project/pull/98204.diff
1 Files Affected:
- (modified) libc/test/src/stdio/sprintf_test.cpp (+4-4)
``````````diff
diff --git a/libc/test/src/stdio/sprintf_test.cpp b/libc/test/src/stdio/sprintf_test.cpp
index 7ccc0a2652e2b..de389e032f895 100644
--- a/libc/test/src/stdio/sprintf_test.cpp
+++ b/libc/test/src/stdio/sprintf_test.cpp
@@ -3351,7 +3351,7 @@ TEST_F(LlvmLibcSPrintfTest, FixedConv) {
LIBC_NAMESPACE::sprintf(buff, "%hR", 0xff); // unsigned short fract max
ASSERT_STREQ_LEN(written, buff, "0.996094");
- written = LIBC_NAMESPACE::sprintf(buff, "%lk", 0x0); // 0.0
+ written = LIBC_NAMESPACE::sprintf(buff, "%lk", 0x0ll); // 0.0
ASSERT_STREQ_LEN(written, buff, "0.000000");
written = LIBC_NAMESPACE::sprintf(buff, "%lk",
@@ -3365,7 +3365,7 @@ TEST_F(LlvmLibcSPrintfTest, FixedConv) {
0xffffffff); //-long fract max
ASSERT_STREQ_LEN(written, buff, "-1.000000");
- written = LIBC_NAMESPACE::sprintf(buff, "%lK", 0x0); // 0.0
+ written = LIBC_NAMESPACE::sprintf(buff, "%lK", 0x0ll); // 0.0
ASSERT_STREQ_LEN(written, buff, "0.000000");
written =
@@ -3493,8 +3493,8 @@ TEST_F(LlvmLibcSPrintfTest, FixedConv) {
ASSERT_STREQ_LEN(written, buff, " 0.100 256.000 ");
written =
- LIBC_NAMESPACE::sprintf(buff, "%+-#12.3lk % 012.3k", 0x000000001013a92a,
- 0x02740000); // 0.126, 1256.0
+ LIBC_NAMESPACE::sprintf(buff, "%+-#12.3lk % 012.3k", 0x000000001013a92all,
+ 0x02740000ll); // 0.126, 1256.0
ASSERT_STREQ_LEN(written, buff, "+0.126 0001256.000");
}
#endif // defined(LIBC_COMPILER_HAS_FIXED_POINT) &&
``````````
</details>
https://github.com/llvm/llvm-project/pull/98204
More information about the libc-commits
mailing list