[libc-commits] [libc] [libc] Use `stdio.h` for `off_t` instead of `unistd.h` (PR #98093)

Mon Jul 8 18:29:00 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `libc` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/2317

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
0.023 [6/14/1] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic_version_script_dummy.x86_64.dir/dummy.cpp.o
0.029 [5/14/2] Building CXX object compiler-rt/lib/ubsan/CMakeFiles/RTUbsan_dynamic_version_script_dummy.x86_64.dir/dummy.cpp.o
0.030 [4/14/3] Building CXX object compiler-rt/lib/hwasan/CMakeFiles/RTHwasan_dynamic_version_script_dummy.x86_64.dir/dummy.cpp.o
0.031 [2/15/4] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic_version_script_dummy.x86_64.dir/dummy.cpp.o
0.083 [1/15/5] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/19/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.so
0.084 [1/14/6] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/19/lib/x86_64-unknown-linux-gnu/libclang_rt.hwasan.so
0.088 [1/13/7] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/19/lib/x86_64-unknown-linux-gnu/libclang_rt.hwasan_aliases.so
0.093 [1/12/8] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/19/lib/x86_64-unknown-linux-gnu/libclang_rt.memprof.so
0.096 [1/11/9] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/19/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.so
0.122 [1/10/10] Building CXX object libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fileno.dir/fileno.cpp.o
FAILED: libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fileno.dir/fileno.cpp.o 
/build/buildbot/premerge-monolithic-linux/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -I/build/buildbot/premerge-monolithic-linux/llvm-project/libc -isystem /build/buildbot/premerge-monolithic-linux/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fpie -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -DLIBC_COPT_RAW_MUTEX_DEFAULT_SPIN_COUNT=100 -DLIBC_COPT_TIMEOUT_ENSURE_MONOTONICITY=1 -std=gnu++17 -MD -MT libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fileno.dir/fileno.cpp.o -MF libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fileno.dir/fileno.cpp.o.d -o libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fileno.dir/fileno.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdio/generic/fileno.cpp
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdio/generic/fileno.cpp:13:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/File/file.h:19:
In file included from /usr/include/stdio.h:42:
/usr/include/x86_64-linux-gnu/bits/types/FILE.h:7:25: error: typedef redefinition with different types ('struct _IO_FILE' vs 'struct FILE')
    7 | typedef struct _IO_FILE FILE;
      |                         ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/include/llvm-libc-types/FILE.h:12:21: note: previous definition is here
   12 | typedef struct FILE FILE;
      |                     ^
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdio/generic/fileno.cpp:13:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/File/file.h:19:
In file included from /usr/include/stdio.h:891:
/usr/include/x86_64-linux-gnu/bits/stdio.h:58:10: error: member access into incomplete type 'FILE'
   58 |   return __getc_unlocked_body (__fp);
      |          ^
/usr/include/x86_64-linux-gnu/bits/types/struct_FILE.h:103:27: note: expanded from macro '__getc_unlocked_body'
  103 |   (__glibc_unlikely ((_fp)->_IO_read_ptr >= (_fp)->_IO_read_end)        \
      |                           ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/include/llvm-libc-types/FILE.h:12:16: note: forward declaration of 'FILE'
   12 | typedef struct FILE FILE;
      |                ^
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdio/generic/fileno.cpp:13:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/File/file.h:19:
In file included from /usr/include/stdio.h:891:
/usr/include/x86_64-linux-gnu/bits/stdio.h:58:10: error: member access into incomplete type 'FILE'
   58 |   return __getc_unlocked_body (__fp);
      |          ^
/usr/include/x86_64-linux-gnu/bits/types/struct_FILE.h:103:50: note: expanded from macro '__getc_unlocked_body'
  103 |   (__glibc_unlikely ((_fp)->_IO_read_ptr >= (_fp)->_IO_read_end)        \
      |                                                  ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/include/llvm-libc-types/FILE.h:12:16: note: forward declaration of 'FILE'
   12 | typedef struct FILE FILE;
      |                ^
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdio/generic/fileno.cpp:13:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/File/file.h:19:
In file included from /usr/include/stdio.h:891:
/usr/include/x86_64-linux-gnu/bits/stdio.h:58:10: error: member access into incomplete type 'FILE'

```

https://github.com/llvm/llvm-project/pull/98093