[libc-commits] [libc] [libc] support out of tree build with dynlibs (PR #97959)

Schrodinger ZHU Yifan via libc-commits libc-commits at lists.llvm.org
Sun Jul 7 09:28:51 PDT 2024


https://github.com/SchrodingerZhu created https://github.com/llvm/llvm-project/pull/97959

None

>From 423c87322986ca8a9bff0e07c50adfd2f6ed5614 Mon Sep 17 00:00:00 2001
From: Schrodinger ZHU Yifan <i at zhuyi.fan>
Date: Sun, 7 Jul 2024 09:27:31 -0700
Subject: [PATCH] [libc] support out of tree build with dynlibs

---
 libc/utils/HdrGen/CMakeLists.txt           | 4 +++-
 libc/utils/LibcTableGenUtil/CMakeLists.txt | 8 ++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/libc/utils/HdrGen/CMakeLists.txt b/libc/utils/HdrGen/CMakeLists.txt
index 0ec1cba542d400..47f845b9f9a5bb 100644
--- a/libc/utils/HdrGen/CMakeLists.txt
+++ b/libc/utils/HdrGen/CMakeLists.txt
@@ -1,6 +1,8 @@
 include(TableGen)
 
-set(LLVM_LINK_COMPONENTS Support)
+if (NOT LLVM_LINK_LLVM_DYLIB)
+  set(LLVM_LINK_COMPONENTS Support)
+endif()
 
 add_tablegen(libc-hdrgen LIBC
   Command.h
diff --git a/libc/utils/LibcTableGenUtil/CMakeLists.txt b/libc/utils/LibcTableGenUtil/CMakeLists.txt
index dca6a7bb830655..9421383394a359 100644
--- a/libc/utils/LibcTableGenUtil/CMakeLists.txt
+++ b/libc/utils/LibcTableGenUtil/CMakeLists.txt
@@ -1,9 +1,13 @@
+if (NOT LLVM_LINK_LLVM_DYLIB)
+  set(flags "DISABLE_LLVM_LINK_LLVM_DYLIB;LINK_COMPONENTS;Support;TableGen")
+else()
+  set(flags "LINK_COMPONENTS;TableGen")
+endif()
 add_llvm_library(
   LibcTableGenUtil
   APIIndexer.cpp
   APIIndexer.h
-  DISABLE_LLVM_LINK_LLVM_DYLIB
-  LINK_COMPONENTS Support TableGen
+  ${flags}
 )
 target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR})
 target_include_directories(LibcTableGenUtil PRIVATE ${LLVM_INCLUDE_DIR} ${LLVM_MAIN_INCLUDE_DIR})



More information about the libc-commits mailing list