[libc-commits] [libc] [libc] Change the test file names used in readlink_test and readlinkat_test. (PR #97864)
via libc-commits
libc-commits at lists.llvm.org
Fri Jul 5 15:12:29 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: None (lntue)
<details>
<summary>Changes</summary>
Attempting to fix the following errors from the build bots:
```
Failed to match LIBC_NAMESPACE::symlink(LINK_VAL, LINK) against Succeeds(0).
Expected return value to be equal to 0 but got -1.
Expected errno to be equal to "Success" but got "File exists".
```
---
Full diff: https://github.com/llvm/llvm-project/pull/97864.diff
2 Files Affected:
- (modified) libc/test/src/unistd/readlink_test.cpp (+2-2)
- (modified) libc/test/src/unistd/readlinkat_test.cpp (+2-2)
``````````diff
diff --git a/libc/test/src/unistd/readlink_test.cpp b/libc/test/src/unistd/readlink_test.cpp
index 20f3951349118..49ab9c24f4024 100644
--- a/libc/test/src/unistd/readlink_test.cpp
+++ b/libc/test/src/unistd/readlink_test.cpp
@@ -18,9 +18,9 @@ namespace cpp = LIBC_NAMESPACE::cpp;
TEST(LlvmLibcReadlinkTest, CreateAndUnlink) {
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
- constexpr const char *FILENAME = "readlink_test_value";
+ constexpr const char *FILENAME = "readlink_test_file";
auto LINK_VAL = libc_make_test_file_path(FILENAME);
- constexpr const char *FILENAME2 = "readlink.test.link";
+ constexpr const char *FILENAME2 = "readlink_test_file.link";
auto LINK = libc_make_test_file_path(FILENAME2);
LIBC_NAMESPACE::libc_errno = 0;
diff --git a/libc/test/src/unistd/readlinkat_test.cpp b/libc/test/src/unistd/readlinkat_test.cpp
index 39d81d9ba544a..7e1ded5f8a4a1 100644
--- a/libc/test/src/unistd/readlinkat_test.cpp
+++ b/libc/test/src/unistd/readlinkat_test.cpp
@@ -20,9 +20,9 @@ namespace cpp = LIBC_NAMESPACE::cpp;
TEST(LlvmLibcReadlinkatTest, CreateAndUnlink) {
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
- constexpr const char *FILENAME = "readlinkat_test_value";
+ constexpr const char *FILENAME = "readlinkat_test_file";
auto LINK_VAL = libc_make_test_file_path(FILENAME);
- constexpr const char *FILENAME2 = "readlinkat.test.link";
+ constexpr const char *FILENAME2 = "readlinkat_test_file.link";
auto LINK = libc_make_test_file_path(FILENAME2);
LIBC_NAMESPACE::libc_errno = 0;
``````````
</details>
https://github.com/llvm/llvm-project/pull/97864
More information about the libc-commits
mailing list