[libc-commits] [libc] [libc] Fix readlink tests on 32-bit systems (PR #97850)

via libc-commits libc-commits at lists.llvm.org
Fri Jul 5 11:04:14 PDT 2024


================
@@ -30,8 +31,9 @@ TEST(LlvmLibcReadlinkTest, CreateAndUnlink) {
   //   3. Cleanup the symlink created in step #1.
   ASSERT_THAT(LIBC_NAMESPACE::symlink(LINK_VAL, LINK), Succeeds(0));
 
-  char buf[sizeof(LINK_VAL)];
-  ssize_t len = LIBC_NAMESPACE::readlink(LINK, buf, sizeof(buf));
+  char buf[sizeof(FILENAME)];
+  ssize_t len =
+      LIBC_NAMESPACE::readlink(LINK, buf, LIBC_NAMESPACE::strlen(FILENAME));
----------------
lntue wrote:

Can you use `LIBC_NAMESPACE::internal::string_length` from https://github.com/llvm/llvm-project/blob/main/libc/src/string/string_utils.h#L90 instead.

https://github.com/llvm/llvm-project/pull/97850


More information about the libc-commits mailing list