[libc-commits] [libc] 2307d27 - [libc] fix float_comparison_test when an emulator is used to run the test (#97748)

via libc-commits libc-commits at lists.llvm.org
Thu Jul 4 09:33:57 PDT 2024


Author: Mikhail R. Gadelha
Date: 2024-07-04T13:33:54-03:00
New Revision: 2307d270ccbf75dc72e8b4406bc0ec88781328f0

URL: https://github.com/llvm/llvm-project/commit/2307d270ccbf75dc72e8b4406bc0ec88781328f0
DIFF: https://github.com/llvm/llvm-project/commit/2307d270ccbf75dc72e8b4406bc0ec88781328f0.diff

LOG: [libc] fix float_comparison_test when an emulator is used to run the test (#97748)

This patch adds a missing ${CMAKE_CROSSCOMPILING_EMULATOR} to the call to libc_str_to_float_comparison_test so the test can run in an emulator, if required.

This is currently required for the rv32 buildbot, which runs in a qemu emulator.

Added: 
    

Modified: 
    libc/test/src/__support/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/src/__support/CMakeLists.txt b/libc/test/src/__support/CMakeLists.txt
index 98f263b74b7591..e1de08e32ea767 100644
--- a/libc/test/src/__support/CMakeLists.txt
+++ b/libc/test/src/__support/CMakeLists.txt
@@ -239,7 +239,7 @@ if(NOT LIBC_TARGET_OS_IS_GPU)
 
   add_custom_command(TARGET libc_str_to_float_comparison_test
                      POST_BUILD
-                     COMMAND $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
+                     COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
                      DEPENDS ${float_test_file}
                      COMMENT "Test the strtof and strtod implementations against precomputed results."
                      VERBATIM)


        


More information about the libc-commits mailing list