[libc-commits] [libc] [libc] fix float_comparison_test when an emulator is used to run the … (PR #97748)
via libc-commits
libc-commits at lists.llvm.org
Thu Jul 4 08:43:57 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Mikhail R. Gadelha (mikhailramalho)
<details>
<summary>Changes</summary>
…test
This patch adds a missing ${CMAKE_CROSSCOMPILING_EMULATOR} to the call to libc_str_to_float_comparison_test so the test can run in an emulator, if required.
This is currently required for the rv32 buildbot, which runs in a qemu emulator.
---
Full diff: https://github.com/llvm/llvm-project/pull/97748.diff
1 Files Affected:
- (modified) libc/test/src/__support/CMakeLists.txt (+1-1)
``````````diff
diff --git a/libc/test/src/__support/CMakeLists.txt b/libc/test/src/__support/CMakeLists.txt
index ce8413fed7172..1627f5d0f40ec 100644
--- a/libc/test/src/__support/CMakeLists.txt
+++ b/libc/test/src/__support/CMakeLists.txt
@@ -238,7 +238,7 @@ if(NOT LIBC_TARGET_OS_IS_GPU)
add_custom_command(TARGET libc_str_to_float_comparison_test
POST_BUILD
- COMMAND $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
+ COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
DEPENDS ${float_test_file}
COMMENT "Test the strtof and strtod implementations against precomputed results."
VERBATIM)
``````````
</details>
https://github.com/llvm/llvm-project/pull/97748
More information about the libc-commits
mailing list