[libc-commits] [libc] [libc] Add LIBC_NAMESPACE_HIDDEN_DECL macro (PR #97109)

via libc-commits libc-commits at lists.llvm.org
Tue Jul 2 12:06:07 PDT 2024


PiJoules wrote:

> > I'm thinking about moving all of our internal implementation to something like `#define LIBC_NAMESPACE_INTERNAL LIBC_NAMESPACE::internal` and make that has hidden visibility by default. We will only leave entry point functions in `LIBC_NAMESPACE`. WDYT?
> > tagging @frobtech @brooksmoses
> 
> I don't think we need to bother, since we already have a macro that marks all of our "API" functions right? (Maybe errno would need something special?). Figured it's sufficient to make everything hidden except our API functions.

`LIBC_NAMESPACE` is already the internal implementation namespace and the attribute has no affect on how the public C symbols get defined. Those are all controlled by `LLVM_LIBC_FUNCTION_ATTR` I think.

https://github.com/llvm/llvm-project/pull/97109


More information about the libc-commits mailing list