[libc-commits] [libc] [libc] reordered Function class parameters and moved yaml files (PR #97329)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Mon Jul 1 14:03:22 PDT 2024


================
@@ -11,14 +11,14 @@
 
 class Function:
     def __init__(
-        self, standards, return_type, name, arguments, guard=None, attributes=[]
+        self, return_type, name, arguments, standards, guard=None, attributes=[]
----------------
michaelrj-google wrote:

in future, it's better to split unrelated changes into two separate PRs. The rule of thumb is "if you need an 'and' in your commit title it's probably better as two commits"

https://github.com/llvm/llvm-project/pull/97329


More information about the libc-commits mailing list