[libc-commits] [clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

Jon Chesterfield via libc-commits libc-commits at lists.llvm.org
Mon Jul 1 06:03:08 PDT 2024


https://github.com/JonChesterfield requested changes to this pull request.

The amdgpu patch is incorrect, see https://github.com/llvm/llvm-project/pull/96370/

The nvptx lowering looks dubious - values smaller than slot size should be passed with the same alignment as the slot and presently aren't. A struct containing i8, i16 or half should be miscompiled on nvptx as written.

No comment on the libc part.

https://github.com/llvm/llvm-project/pull/96369


More information about the libc-commits mailing list