[libc-commits] [libc] [libc] disable epoll_pwait2 due to breakage (PR #80051)

via libc-commits libc-commits at lists.llvm.org
Tue Jan 30 13:08:14 PST 2024


https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/80051

>From ea79b88cf5de0502e2b54665a0822afddeddc6c5 Mon Sep 17 00:00:00 2001
From: Michael Jones <michaelrj at google.com>
Date: Tue, 30 Jan 2024 12:03:53 -0800
Subject: [PATCH 1/2] [libc] disable epoll_pwait2 due to breakage

It appears that sys_epoll_pwait2 isn't always available, so we need to
add some sort of condition to enable it. This patch disables it until
that happens.
---
 libc/config/linux/x86_64/entrypoints.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 1764157da9a47..8a41a2e92ed9f 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -146,7 +146,8 @@ set(TARGET_LIBC_ENTRYPOINTS
     # sys/epoll.h entrypoints
     libc.src.sys.epoll.epoll_wait
     libc.src.sys.epoll.epoll_pwait
-    libc.src.sys.epoll.epoll_pwait2
+    # Need to check if pwait2 is available before providing.
+    # libc.src.sys.epoll.epoll_pwait2
 
     # sys/mman.h entrypoints
     libc.src.sys.mman.madvise

>From b3ce9955ee18d35ed40d7fae7a5e3ab1787de4a2 Mon Sep 17 00:00:00 2001
From: Michael Jones <michaelrj at google.com>
Date: Tue, 30 Jan 2024 13:07:56 -0800
Subject: [PATCH 2/2] add comment with link to issue

---
 libc/config/linux/x86_64/entrypoints.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 8a41a2e92ed9f..a03efa89b8e8e 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -146,7 +146,8 @@ set(TARGET_LIBC_ENTRYPOINTS
     # sys/epoll.h entrypoints
     libc.src.sys.epoll.epoll_wait
     libc.src.sys.epoll.epoll_pwait
-    # Need to check if pwait2 is available before providing.
+    # TODO: Need to check if pwait2 is available before providing.
+    # https://github.com/llvm/llvm-project/issues/80060
     # libc.src.sys.epoll.epoll_pwait2
 
     # sys/mman.h entrypoints



More information about the libc-commits mailing list