[libc-commits] [libc] [fuchsia][libc] Include missing macro definitions (PR #79639)

[Caslyn Tonelli via libc-commits]

Caslyn wrote:

Hi @gchatelet  - don't worry, these kind of Fuchsia-specific fixes to libc tests are considered part of Fuchsia maintenance.

We have a particular set of rollers that integrate llvm-libc changes into Fuchsia. The way that llvm-libc is built and used in Fuchsia requires the entire Fuchsia checkout, which is big enough (~80GB) to be prohibitive to build and run on an upstream buildbot to catch these kind of errors.  Also, a portion of the time the errors that we see from our libc integration roller requires a fix in Fuchsia itself and is not the fault of the llvm committer.

Our team discussed the possibility of building libc unittests against the Fuchsia sdk, but that would not have caught this error.

https://github.com/llvm/llvm-project/pull/79639