[libc-commits] [libc] [libc] Use `LIBC_COPT_PUBLIC_PACKAGING` for hermetic and integration tests. (PR #79319)

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Fri Jan 26 00:56:02 PST 2024


================
@@ -47,7 +47,7 @@ static void *successThread(void *Arg) {
   pthread_t th = LIBC_NAMESPACE::pthread_self();
   auto *thread = reinterpret_cast<LIBC_NAMESPACE::Thread *>(&th);
 
-  ASSERT_EQ(libc_errno, 0);
+  ASSERT_EQ(static_cast<int>(libc_errno), 0);
----------------
gchatelet wrote:

I think this deserves an `ASSERT_ERREQ` macro in our gtest.
The `static_cast<int>` adds a lot of clutter and will be surprising to newcomers.

Given the size of this change I'd like to do it as a separate change if possible. I'll come back with such a patch and ping here.

https://github.com/llvm/llvm-project/pull/79319


More information about the libc-commits mailing list