[libc-commits] [libc] 4a9b5aa - [libc][NFC] remove TODO about AppProperties (#79356)
via libc-commits
libc-commits at lists.llvm.org
Wed Jan 24 12:18:15 PST 2024
Author: Schrodinger ZHU Yifan
Date: 2024-01-24T15:18:11-05:00
New Revision: 4a9b5aa1164c1eff68c98c1513cab3ac0c52b4af
URL: https://github.com/llvm/llvm-project/commit/4a9b5aa1164c1eff68c98c1513cab3ac0c52b4af
DIFF: https://github.com/llvm/llvm-project/commit/4a9b5aa1164c1eff68c98c1513cab3ac0c52b4af.diff
LOG: [libc][NFC] remove TODO about AppProperties (#79356)
```
AppProperties app;
```
is marked as a weak symbol in header now. One can just use `&app !=
nullptr` to check if `app` is defined. There is no need to define it for
overlay mode.
Added:
Modified:
libc/startup/linux/do_start.cpp
Removed:
################################################################################
diff --git a/libc/startup/linux/do_start.cpp b/libc/startup/linux/do_start.cpp
index 10b215cdc27b7e..55fd575f7ad0b0 100644
--- a/libc/startup/linux/do_start.cpp
+++ b/libc/startup/linux/do_start.cpp
@@ -37,7 +37,6 @@ extern uintptr_t __fini_array_end[];
}
namespace LIBC_NAMESPACE {
-// TODO: this symbol will be moved to config.linux.app
AppProperties app;
using InitCallback = void(int, char **, char **);
More information about the libc-commits
mailing list