[libc-commits] [libc] [libc][NFC] remove TODO about AppProperties (PR #79356)

[via libc-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

<details>
<summary>Changes</summary>

```
AppProperties app;
```
is marked as a weak symbol in header now. One can just use `&app != nullptr` to check if `app` is defined. There is no need to define it for overlay mode.

---
Full diff: https://github.com/llvm/llvm-project/pull/79356.diff


1 Files Affected:

- (modified) libc/startup/linux/do_start.cpp (-1) 


``````````diff
diff --git a/libc/startup/linux/do_start.cpp b/libc/startup/linux/do_start.cpp
index 10b215cdc27b7e4..55fd575f7ad0b02 100644
--- a/libc/startup/linux/do_start.cpp
+++ b/libc/startup/linux/do_start.cpp
@@ -37,7 +37,6 @@ extern uintptr_t __fini_array_end[];
 }
 
 namespace LIBC_NAMESPACE {
-// TODO: this symbol will be moved to config.linux.app
 AppProperties app;
 
 using InitCallback = void(int, char **, char **);

``````````

</details>


https://github.com/llvm/llvm-project/pull/79356