[libc-commits] [libc] [libc][NFC] remove TODO about AppProperties (PR #79356)

Schrodinger ZHU Yifan via libc-commits libc-commits at lists.llvm.org
Wed Jan 24 12:13:24 PST 2024


https://github.com/SchrodingerZhu created https://github.com/llvm/llvm-project/pull/79356

```
AppProperties app;
```
is marked as weak symbol now. One can just `&app != nullptr` to check if `app` is defined. There is no need to define it for overlay mode.

>From 1c6d813794f4c0494f53788b4deff24d73d1e144 Mon Sep 17 00:00:00 2001
From: Schrodinger ZHU Yifan <yifanzhu at rochester.edu>
Date: Wed, 24 Jan 2024 15:11:58 -0500
Subject: [PATCH] [libc][NFC] remove TODO about AppProperties

---
 libc/startup/linux/do_start.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libc/startup/linux/do_start.cpp b/libc/startup/linux/do_start.cpp
index 10b215cdc27b7e..55fd575f7ad0b0 100644
--- a/libc/startup/linux/do_start.cpp
+++ b/libc/startup/linux/do_start.cpp
@@ -37,7 +37,6 @@ extern uintptr_t __fini_array_end[];
 }
 
 namespace LIBC_NAMESPACE {
-// TODO: this symbol will be moved to config.linux.app
 AppProperties app;
 
 using InitCallback = void(int, char **, char **);



More information about the libc-commits mailing list