[libc-commits] [libc] [libc] Simple __stack_chk_guard implementation (PR #78804)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Jan 22 10:13:07 PST 2024


================
@@ -19,6 +19,7 @@ set(TARGET_LIBC_ENTRYPOINTS
 
     # compiler entrypoints (no corresponding header)
     libc.src.compiler.__stack_chk_fail
+    libc.src.compiler.__stack_chk_guard
----------------
nickdesaulniers wrote:

libc/src/compiler/__stack_chk_guard.h is not specific to baremetal.  Both that header and libc/src/compiler/linux/__stack_chk_guard.cpp declare `__stack_chk_guard` as non-TLS.  Shouldn't they be declaring `__stack_chk_guard` as `__thread` in order to be thread local?

cc @SchrodingerZhu 

https://github.com/llvm/llvm-project/pull/78804


More information about the libc-commits mailing list