[libc-commits] [libc] [libc][NFC] Introduce a Sign type for FPBits (PR #78500)

Clement Courbet via libc-commits libc-commits at lists.llvm.org
Thu Jan 18 02:12:40 PST 2024


================
@@ -437,7 +438,7 @@ LLVM_LIBC_FUNCTION(double, expm1, (double x)) {
 
   double lo = fputil::multiply_add(p, mid_lo, hi_part.lo);
 
-  uint64_t err = x_sign ? (static_cast<uint64_t>(-hi) << 52) : 0;
+  uint64_t err = x_is_neg ? (static_cast<uint64_t>(-hi) << 52) : 0;
----------------
legrosbuffle wrote:

This seems to break the encoding abstraction. Let's add a FIXME.

https://github.com/llvm/llvm-project/pull/78500


More information about the libc-commits mailing list