[libc-commits] [libc] [libc][cmake] reset COMPILE_DEFINITIONS (PR #77810)
Louis Dionne via libc-commits
libc-commits at lists.llvm.org
Fri Jan 12 14:24:33 PST 2024
ldionne wrote:
I think this makes sense, however I'll note that other things can be polluted by the "rest" of LLVM as well:
- Link flags
- CMake variables like `CMAKE_POSITION_INDEPENDENT_CODE`
- Other compiler flags that are not `-D` options
This is better than nothing, but I think the full fix is to gradually refactor the CMake files used by runtimes to avoid setting anything global.
https://github.com/llvm/llvm-project/pull/77810
More information about the libc-commits
mailing list