[libc-commits] [libc] [libc] Disable Death Tests While Hermetic (PR #77388)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Tue Jan 9 10:42:43 PST 2024


jhuber6 wrote:

> Seems fine to disable for now, but I would prefer:
> 
>     1. file an issue to see how to fix this more properly (by providing a definition of `operator new` that the linker is complaining about).
> 
>     2. link to that issue in a comment in the cmake files.
> 
> 
> Folks are probably going to keep hitting this issue as they write more and more death tests.

My understanding was that death tests are always disabled when doing hermetic tests, so they should always be `UNIT_TEST_ONLY`. Maybe what happened is someone added those into a single test without knowing that death tests need to be separate. 

https://github.com/llvm/llvm-project/pull/77388


More information about the libc-commits mailing list