[libc-commits] [libc] [libc] Fix installed 'math.h' header paths (PR #83199)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Feb 27 15:25:36 PST 2024


================
@@ -9,8 +9,6 @@
 #ifndef __LLVM_LIBC_TYPES_FLOAT128_H__
 #define __LLVM_LIBC_TYPES_FLOAT128_H__
 
-#include <include/llvm-libc-macros/float-macros.h> // LDBL_MANT_DIG
----------------
nickdesaulniers wrote:

Consistency is good.  So is brevity; `#include "include/...` looks silly to me and if your cmake change allows us to omit the extra include everywhere, I think the result would still be consistent, and then we don't have an undocumented convention that will get out of sync again. 

https://github.com/llvm/llvm-project/pull/83199


More information about the libc-commits mailing list