[libc-commits] [libc] [libc][NFC] Remove redundant external clock symbol for AMDGPU (PR #82794)
via libc-commits
libc-commits at lists.llvm.org
Fri Feb 23 09:03:33 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Joseph Huber (jhuber6)
<details>
<summary>Changes</summary>
Summary:
The AMDGPU target needs an external clock symbol so the driver can set
the frequency with the correct value. This was left over from the
previous implementation and I forgot to remove it when actually
implementing the timing utilities.
---
Full diff: https://github.com/llvm/llvm-project/pull/82794.diff
1 Files Affected:
- (modified) libc/startup/gpu/amdgpu/start.cpp (-6)
``````````diff
diff --git a/libc/startup/gpu/amdgpu/start.cpp b/libc/startup/gpu/amdgpu/start.cpp
index 9d7f04c10b4882..dcef719d169d07 100644
--- a/libc/startup/gpu/amdgpu/start.cpp
+++ b/libc/startup/gpu/amdgpu/start.cpp
@@ -15,12 +15,6 @@ extern "C" int main(int argc, char **argv, char **envp);
namespace LIBC_NAMESPACE {
-// The AMDGPU architecture provides a fixed frequency clock used for obtaining
-// real time. However, the frequency of this clock varies between cards and can
-// only be obtained via the driver. The loader will set this so we can use it.
-extern "C" [[gnu::visibility("protected")]] uint64_t
- [[clang::address_space(4)]] __llvm_libc_clock_freq = 0;
-
extern "C" uintptr_t __init_array_start[];
extern "C" uintptr_t __init_array_end[];
extern "C" uintptr_t __fini_array_start[];
``````````
</details>
https://github.com/llvm/llvm-project/pull/82794
More information about the libc-commits
mailing list