[libc-commits] [libc] [libc][NFC] Remove redundant external clock symbol for AMDGPU (PR #82794)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Fri Feb 23 09:02:59 PST 2024


https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/82794

Summary:
The AMDGPU target needs an external clock symbol so the driver can set
the frequency with the correct value. This was left over from the
previous implementation and I forgot to remove it when actually
implementing the timing utilities.


>From e0474bf7198bd05dee13bf910e83808f59d16471 Mon Sep 17 00:00:00 2001
From: Joseph Huber <huberjn at outlook.com>
Date: Fri, 23 Feb 2024 11:01:27 -0600
Subject: [PATCH] [libc][NFC] Remove redundant external clock symbol for AMDGPU

Summary:
The AMDGPU target needs an external clock symbol so the driver can set
the frequency with the correct value. This was left over from the
previous implementation and I forgot to remove it when actually
implementing the timing utilities.
---
 libc/startup/gpu/amdgpu/start.cpp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/libc/startup/gpu/amdgpu/start.cpp b/libc/startup/gpu/amdgpu/start.cpp
index 9d7f04c10b4882..dcef719d169d07 100644
--- a/libc/startup/gpu/amdgpu/start.cpp
+++ b/libc/startup/gpu/amdgpu/start.cpp
@@ -15,12 +15,6 @@ extern "C" int main(int argc, char **argv, char **envp);
 
 namespace LIBC_NAMESPACE {
 
-// The AMDGPU architecture provides a fixed frequency clock used for obtaining
-// real time. However, the frequency of this clock varies between cards and can
-// only be obtained via the driver. The loader will set this so we can use it.
-extern "C" [[gnu::visibility("protected")]] uint64_t
-    [[clang::address_space(4)]] __llvm_libc_clock_freq = 0;
-
 extern "C" uintptr_t __init_array_start[];
 extern "C" uintptr_t __init_array_end[];
 extern "C" uintptr_t __fini_array_start[];



More information about the libc-commits mailing list