[libc-commits] [libc] Add explicit conversion to fix arm64 builds. (PR #82429)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Tue Feb 20 14:49:46 PST 2024


https://github.com/michaelrj-google approved this pull request.

I don't think we're requiring `LIBC_INLINE_ASM` right now, but it's a macro for marking asm calls, defined here: https://github.com/llvm/llvm-project/blob/main/libc/src/__support/macros/attributes.h#L24

I remember there being some discussion around deprecating it, since marking all of our asm as volatile pessimizes any optimization. In theory it would allow a user to redefine that macro and set their own asm attributes.

Regardless, it's out of scope for this patch. This patch is fine to land as is. If you don't have commit access then just ping me and I'll land it for you.

https://github.com/llvm/llvm-project/pull/82429


More information about the libc-commits mailing list