[libc-commits] [libc] [libc] Fix generated float128 header for aarch64 target. (PR #78017)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Fri Feb 2 11:16:40 PST 2024


nickdesaulniers wrote:

I think you should drop https://github.com/llvm/llvm-project/pull/78017/commits/76aedc891307c10cd58b448ae89189c20d577330

The point of feature detection is that when any toolchain implements support and advertises that, the checks we have just work.

We should only check for advertised support of the feature, unless something is very very wrong in the compiler (in which adequate commentary on why is necessary).

https://github.com/llvm/llvm-project/pull/78017


More information about the libc-commits mailing list