[libc-commits] [libc] [libc][stdbit] implement stdc_trailing_ones (C23) (PR #80459)

[via libc-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff edbd93d3706b806e7c91dfd2c359476488dfcc96 c6f1206d622286629761dd67bcbdf4fc6f2dc3cf -- libc/src/stdbit/stdc_trailing_ones_uc.cpp libc/src/stdbit/stdc_trailing_ones_uc.h libc/src/stdbit/stdc_trailing_ones_ui.cpp libc/src/stdbit/stdc_trailing_ones_ui.h libc/src/stdbit/stdc_trailing_ones_ul.cpp libc/src/stdbit/stdc_trailing_ones_ul.h libc/src/stdbit/stdc_trailing_ones_ull.cpp libc/src/stdbit/stdc_trailing_ones_ull.h libc/src/stdbit/stdc_trailing_ones_us.cpp libc/src/stdbit/stdc_trailing_ones_us.h libc/src/stdbit/stdc_trailing_zeros_uc.cpp libc/src/stdbit/stdc_trailing_zeros_uc.h libc/src/stdbit/stdc_trailing_zeros_ui.cpp libc/src/stdbit/stdc_trailing_zeros_ui.h libc/src/stdbit/stdc_trailing_zeros_ul.cpp libc/src/stdbit/stdc_trailing_zeros_ul.h libc/src/stdbit/stdc_trailing_zeros_ull.cpp libc/src/stdbit/stdc_trailing_zeros_ull.h libc/src/stdbit/stdc_trailing_zeros_us.cpp libc/src/stdbit/stdc_trailing_zeros_us.h libc/test/src/stdbit/stdc_trailing_ones_uc_test.cpp libc/test/src/stdbit/stdc_trailing_ones_ui_test.cpp libc/test/src/stdbit/stdc_trailing_ones_ul_test.cpp libc/test/src/stdbit/stdc_trailing_ones_us_test.cpp libc/test/src/stdbit/stdc_trailing_zeros_uc_test.cpp libc/test/src/stdbit/stdc_trailing_zeros_ui_test.cpp libc/test/src/stdbit/stdc_trailing_zeros_ul_test.cpp libc/test/src/stdbit/stdc_trailing_zeros_ull_test.cpp libc/test/src/stdbit/stdc_trailing_zeros_us_test.cpp libc/include/llvm-libc-macros/stdbit-macros.h libc/test/include/stdbit_test.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libc/include/llvm-libc-macros/stdbit-macros.h b/libc/include/llvm-libc-macros/stdbit-macros.h
index 840246b795..d58ab7127c 100644
--- a/libc/include/llvm-libc-macros/stdbit-macros.h
+++ b/libc/include/llvm-libc-macros/stdbit-macros.h
@@ -92,12 +92,12 @@ inline unsigned stdc_trailing_ones(unsigned long long x) {
       unsigned: stdc_trailing_zeros_ui,                                        \
       unsigned long: stdc_trailing_zeros_ul,                                   \
       unsigned long long: stdc_trailing_zeros_ull)(x)
-#define stdc_trailing_ones(x)                                                 \
+#define stdc_trailing_ones(x)                                                  \
   _Generic((x),                                                                \
-      unsigned char: stdc_trailing_ones_uc,                                   \
-      unsigned short: stdc_trailing_ones_us,                                  \
-      unsigned: stdc_trailing_ones_ui,                                        \
-      unsigned long: stdc_trailing_ones_ul,                                   \
+      unsigned char: stdc_trailing_ones_uc,                                    \
+      unsigned short: stdc_trailing_ones_us,                                   \
+      unsigned: stdc_trailing_ones_ui,                                         \
+      unsigned long: stdc_trailing_ones_ul,                                    \
       unsigned long long: stdc_trailing_ones_ull)(x)
 #endif // __cplusplus
 
diff --git a/libc/src/stdbit/stdc_trailing_ones_ull.cpp b/libc/src/stdbit/stdc_trailing_ones_ull.cpp
index 883b1f2ff5..fb5fffe078 100644
--- a/libc/src/stdbit/stdc_trailing_ones_ull.cpp
+++ b/libc/src/stdbit/stdc_trailing_ones_ull.cpp
@@ -13,7 +13,8 @@
 
 namespace LIBC_NAMESPACE {
 
-LLVM_LIBC_FUNCTION(unsigned, stdc_trailing_ones_ull, (unsigned long long value)) {
+LLVM_LIBC_FUNCTION(unsigned, stdc_trailing_ones_ull,
+                   (unsigned long long value)) {
   return static_cast<unsigned>(cpp::countr_one(value));
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/80459