[libc-commits] [libc] [libc] express proper dependencies for stdbit include test (PR #80318)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Thu Feb 1 10:56:02 PST 2024


================
@@ -17,7 +17,18 @@ add_libc_test(
 
 # stdbit_test only tests our generated stdbit.h, which is not generated in
 # overlay mode.
-if(LLVM_LIBC_FULL_BUILD AND libc.include.stdbit IN_LIST TARGET_PUBLIC_HEADERS)
+message(STATUS "TARGET_PUBLIC_HEADERS is ${TARGET_PUBLIC_HEADERS}")
+if(LLVM_LIBC_FULL_BUILD AND libc.include.stdbit IN_LIST TARGET_PUBLIC_HEADERS
+    AND libc.src.stdbit.stdc_leading_zeros_uc IN_LIST TARGET_LLVMLIBC_ENTRYPOINTS
----------------
nickdesaulniers wrote:

So I think the issue with that approach though would be that those then get linked into the test?

Hmm...what do you think about this approach instead?
https://github.com/llvm/llvm-project/pull/80323

https://github.com/llvm/llvm-project/pull/80318


More information about the libc-commits mailing list