[libc-commits] [libc] [libc] process mrelease (PR #119147)

Omar Hossam via libc-commits libc-commits at lists.llvm.org
Sat Dec 21 00:41:30 PST 2024


moar55 wrote:

> a couple of nits, but looks fine overall.
> 
> Ideally the test would have both a trivially failing call and a trivially succeeding call, to exercise both sides of the branch.

I used to have the trivially succeeding call but they mentioned it is best not to test syscalls in the unit test because it was causing issues in the pipeline. Or maybe i misunderstood it, but i needed a syscall (namely pifd_open) to test this one.
@SchrodingerZhu ?

https://github.com/llvm/llvm-project/pull/119147


More information about the libc-commits mailing list