[libc-commits] [libc] [libc] update host build docs (PR #120147)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Dec 16 13:50:31 PST 2024


================
@@ -252,29 +252,29 @@ add_libc_test(
 # FIXME: We shouldn't have regular executables created because we could be
 #        cross-compiling the tests and running through an emulator.
 if(NOT LIBC_TARGET_OS_IS_GPU)
-  add_executable(
-    libc_str_to_float_comparison_test
-    str_to_float_comparison_test.cpp
-  )
+  # add_executable(
+  #   libc_str_to_float_comparison_test
+  #   str_to_float_comparison_test.cpp
+  # )
 
-  target_link_libraries(libc_str_to_float_comparison_test
-    PRIVATE
-      "${LIBC_TARGET}"
-  )
+  # target_link_libraries(libc_str_to_float_comparison_test
+  #   PRIVATE
+  #     "${LIBC_TARGET}"
+  # )
 
-  add_executable(
-    libc_system_str_to_float_comparison_test
-    str_to_float_comparison_test.cpp
-  )
+  # add_executable(
+  #   libc_system_str_to_float_comparison_test
+  #   str_to_float_comparison_test.cpp
+  # )
 
-  set(float_test_file ${CMAKE_CURRENT_SOURCE_DIR}/str_to_float_comparison_data.txt)
+  # set(float_test_file ${CMAKE_CURRENT_SOURCE_DIR}/str_to_float_comparison_data.txt)
 
-  add_custom_command(TARGET libc_str_to_float_comparison_test
-                     POST_BUILD
-                     COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
-                     DEPENDS ${float_test_file}
-                     COMMENT "Test the strtof and strtod implementations against precomputed results."
-                     VERBATIM)
+  # add_custom_command(TARGET libc_str_to_float_comparison_test
+  #                    POST_BUILD
+  #                    COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:libc_str_to_float_comparison_test> ${float_test_file}
+  #                    DEPENDS ${float_test_file}
+  #                    COMMENT "Test the strtof and strtod implementations against precomputed results."
+  #                    VERBATIM)
----------------
nickdesaulniers wrote:

You probably didn't mean to commit changes to this file?

https://github.com/llvm/llvm-project/pull/120147


More information about the libc-commits mailing list