[libc-commits] [libc] [libc] move bcmp, bzero, bcopy, index, rindex, strcasecmp, strncasecmp to strings.h (PR #118899)

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Mon Dec 9 12:18:00 PST 2024


================
@@ -246,6 +246,7 @@ int CmpBlockAdaptor(cpp::span<char> p1, cpp::span<char> p2, size_t size) {
   return (int)FnImpl(as_byte(p1), as_byte(p2));
 }
 
+// TODO: should testing of bcmp be moved to libc/test/src/strings/ dir?
----------------
gchatelet wrote:

It makes sense for unit tests and fuzz tests to move to a `strings` folder but `op_tests` is about testing the low level constructs and I think it's fine to keep them here.

https://github.com/llvm/llvm-project/pull/118899


More information about the libc-commits mailing list