[libc-commits] [libc] [libc] revert all process_mrelease changes (PR #118650)

Omar Hossam via libc-commits libc-commits at lists.llvm.org
Wed Dec 4 11:29:21 PST 2024


moar55 wrote:

> @moar55 instead of stacking more fixes, let's just revert the changes. If you have time, could you resubmit this patch and removing all tests but the one testing the invalid argument? As @lntue said, we should not test syscall's correctness in libc's unittests.

Is this the one you mean with the one testing invalid argument:
```
TEST(LlvmLibcProcessMReleaseTest, ErrorNonExistingPidfd) {
  EXPECT_THAT(LIBC_NAMESPACE::process_mrelease(-1, 0), Fails(EBADF));
}
```
?

https://github.com/llvm/llvm-project/pull/118650


More information about the libc-commits mailing list