[libc-commits] [libc] Fixes #118231: Corrected spelling mistake in has_acitive_owner function (PR #118266)

via libc-commits libc-commits at lists.llvm.org
Sun Dec 1 23:04:04 PST 2024


https://github.com/firestrike007 created https://github.com/llvm/llvm-project/pull/118266

- Updated the method name to `has_active_owner` in `llvm-project/libc/src/__support/threads/linux/rwlock.h`
- Verified usage and updated all references to the method.
- Ran tests:
    - `check-llvm-unit`
    - `check-all`

>From 0c81536ad9a67f56837d3cf5f8752fa1b344ff9d Mon Sep 17 00:00:00 2001
From: firestrike007 <cshankhin at gmail.com>
Date: Mon, 2 Dec 2024 01:41:01 -0500
Subject: [PATCH] Fix issue in has_acitve_owner in rwlock.h

---
 libc/src/__support/threads/linux/rwlock.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libc/src/__support/threads/linux/rwlock.h b/libc/src/__support/threads/linux/rwlock.h
index 57fcc7bb67a6a0..f7aeb5b709aa3e 100644
--- a/libc/src/__support/threads/linux/rwlock.h
+++ b/libc/src/__support/threads/linux/rwlock.h
@@ -162,7 +162,7 @@ class RwState {
   LIBC_INLINE constexpr bool has_active_reader() const {
     return state >= ACTIVE_READER_COUNT_UNIT;
   }
-  LIBC_INLINE constexpr bool has_acitve_owner() const {
+  LIBC_INLINE constexpr bool has_active_owner() const {
     return has_active_reader() || has_active_writer();
   }
   LIBC_INLINE constexpr bool has_last_reader() const {
@@ -193,7 +193,7 @@ class RwState {
       }
       __builtin_unreachable();
     } else
-      return !has_acitve_owner();
+      return !has_active_owner();
   }
 
   // This function check if it is possible to grow the reader count without
@@ -548,7 +548,7 @@ class RwLock {
   [[nodiscard]]
   LIBC_INLINE LockResult check_for_destroy() {
     RwState old = RwState::load(state, cpp::MemoryOrder::RELAXED);
-    if (old.has_acitve_owner())
+    if (old.has_active_owner())
       return LockResult::Busy;
     return LockResult::Success;
   }



More information about the libc-commits mailing list