[libc-commits] [libc] 439d7de - [libc] Disable failing scanf test on AMDGPU temporarily

[Joseph Huber via libc-commits]

Author: Joseph Huber
Date: 2024-08-28T07:04:15-05:00
New Revision: 439d7de14d71216c269ecda47baed067ab03795a

URL: https://github.com/llvm/llvm-project/commit/439d7de14d71216c269ecda47baed067ab03795a
DIFF: https://github.com/llvm/llvm-project/commit/439d7de14d71216c269ecda47baed067ab03795a.diff

LOG: [libc] Disable failing scanf test on AMDGPU temporarily

Summary:
This test currently fails in the `amdgpu-attributor` pass. I haven't
figured out anything beyond that yet as it's difficult to reduce.

Added: 
    

Modified: 
    libc/config/gpu/entrypoints.txt
    libc/test/src/stdio/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/config/gpu/entrypoints.txt b/libc/config/gpu/entrypoints.txt
index 7b869902074d8e..db7cd24dadb7fc 100644
--- a/libc/config/gpu/entrypoints.txt
+++ b/libc/config/gpu/entrypoints.txt
@@ -207,7 +207,9 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.stdio.asprintf
     libc.src.stdio.vasprintf
     libc.src.stdio.scanf
+    libc.src.stdio.vscanf
     libc.src.stdio.fscanf
+    libc.src.stdio.vfscanf
     libc.src.stdio.sscanf
     libc.src.stdio.vsscanf
     libc.src.stdio.feof

diff  --git a/libc/test/src/stdio/CMakeLists.txt b/libc/test/src/stdio/CMakeLists.txt
index d7b88186b5704a..00379ba1877e82 100644
--- a/libc/test/src/stdio/CMakeLists.txt
+++ b/libc/test/src/stdio/CMakeLists.txt
@@ -272,33 +272,37 @@ if(LLVM_LIBC_FULL_BUILD)
   )
 endif()
 
-add_libc_test(
-  fscanf_test
-  SUITE
-    libc_stdio_unittests
-  SRCS
-    fscanf_test.cpp
-  DEPENDS
-    libc.src.stdio.fscanf
-    ${fscanf_test_deps}
-    libc.src.__support.CPP.string_view
-  COMPILE_OPTIONS
-    ${use_system_file}
-)
+# FIXME: These tests currently fail on AMDGPU due to an optimization bug in the
+#        `amdgpu-attributor` pass. Disable until that's fixed.
+if(NOT LIBC_TARGET_ARCHITECTURE_IS_AMDGPU)
+  add_libc_test(
+    fscanf_test
+    SUITE
+      libc_stdio_unittests
+    SRCS
+      fscanf_test.cpp
+    DEPENDS
+      libc.src.stdio.fscanf
+      ${fscanf_test_deps}
+      libc.src.__support.CPP.string_view
+    COMPILE_OPTIONS
+      ${use_system_file}
+  )
 
-add_libc_test(
-  vfscanf_test
-  SUITE
-    libc_stdio_unittests
-  SRCS
-    vfscanf_test.cpp
-  DEPENDS
-    libc.src.stdio.vfscanf
-    ${fscanf_test_deps}
-    libc.src.__support.CPP.string_view
-  COMPILE_OPTIONS
-    ${use_system_file}
-)
+  add_libc_test(
+    vfscanf_test
+    SUITE
+      libc_stdio_unittests
+    SRCS
+      vfscanf_test.cpp
+    DEPENDS
+      libc.src.stdio.vfscanf
+      ${fscanf_test_deps}
+      libc.src.__support.CPP.string_view
+    COMPILE_OPTIONS
+      ${use_system_file}
+  )
+endif()
 
 if(LIBC_CONF_SCANF_DISABLE_FLOAT)
   list(APPEND sscanf_test_copts "-DLIBC_COPT_SCANF_DISABLE_FLOAT")