[libc-commits] [libc] [libc] Fix unit test compile flags propagation. (PR #106128)

via libc-commits libc-commits at lists.llvm.org
Wed Aug 28 04:00:38 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 178fc4779ece31392a2cd01472b0279e50b3a199 10244908b1691a26214dbcb603bb12a424a968f3 --extensions cpp -- libc/test/src/math/smoke/nan_test.cpp libc/test/src/math/smoke/nanf128_test.cpp libc/test/src/math/smoke/nanf16_test.cpp libc/test/src/math/smoke/nanl_test.cpp libc/test/src/sys/mman/linux/madvise_test.cpp libc/test/src/sys/mman/linux/mincore_test.cpp libc/test/src/sys/mman/linux/mlock_test.cpp libc/test/src/sys/mman/linux/msync_test.cpp libc/test/src/sys/mman/linux/posix_madvise_test.cpp libc/test/src/termios/termios_test.cpp libc/test/src/unistd/pread_pwrite_test.cpp libc/test/src/unistd/read_write_test.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libc/test/src/sys/mman/linux/mincore_test.cpp b/libc/test/src/sys/mman/linux/mincore_test.cpp
index 895d748c59..8ba7336c3d 100644
--- a/libc/test/src/sys/mman/linux/mincore_test.cpp
+++ b/libc/test/src/sys/mman/linux/mincore_test.cpp
@@ -40,8 +40,8 @@ TEST(LlvmLibcMincoreTest, UnalignedAddr) {
   EXPECT_NE(addr, MAP_FAILED);
   EXPECT_EQ(reinterpret_cast<unsigned long>(addr) % page_size, 0ul);
   LIBC_NAMESPACE::libc_errno = 0;
-  // int res = LIBC_NAMESPACE::mincore(static_cast<char *>(addr) + 1, 1, nullptr);
-  // EXPECT_THAT(res, Fails(EINVAL, -1));
+  // int res = LIBC_NAMESPACE::mincore(static_cast<char *>(addr) + 1, 1,
+  // nullptr); EXPECT_THAT(res, Fails(EINVAL, -1));
   EXPECT_THAT(LIBC_NAMESPACE::munmap(addr, page_size), Succeeds());
 }
 
diff --git a/libc/test/src/sys/mman/linux/mlock_test.cpp b/libc/test/src/sys/mman/linux/mlock_test.cpp
index d1e77cb6c8..0616958642 100644
--- a/libc/test/src/sys/mman/linux/mlock_test.cpp
+++ b/libc/test/src/sys/mman/linux/mlock_test.cpp
@@ -95,17 +95,20 @@ TEST(LlvmLibcMlockTest, Overflow) {
 TEST(LlvmLibcMlockTest, MLock2) {
   // PageHolder holder;
   // EXPECT_TRUE(holder.is_valid());
-  // EXPECT_THAT(LIBC_NAMESPACE::madvise(holder.addr, holder.size, MADV_DONTNEED),
+  // EXPECT_THAT(LIBC_NAMESPACE::madvise(holder.addr, holder.size,
+  // MADV_DONTNEED),
   //             Succeeds());
-  // EXPECT_THAT(LIBC_NAMESPACE::mlock2(holder.addr, holder.size, 0), Succeeds());
-  // unsigned char vec;
+  // EXPECT_THAT(LIBC_NAMESPACE::mlock2(holder.addr, holder.size, 0),
+  // Succeeds()); unsigned char vec;
   // EXPECT_THAT(LIBC_NAMESPACE::mincore(holder.addr, holder.size, &vec),
   //             Succeeds());
   // EXPECT_EQ(vec & 1, 1);
   // EXPECT_THAT(LIBC_NAMESPACE::munlock(holder.addr, holder.size), Succeeds());
-  // EXPECT_THAT(LIBC_NAMESPACE::madvise(holder.addr, holder.size, MADV_DONTNEED),
+  // EXPECT_THAT(LIBC_NAMESPACE::madvise(holder.addr, holder.size,
+  // MADV_DONTNEED),
   //             Succeeds());
-  // EXPECT_THAT(LIBC_NAMESPACE::mlock2(holder.addr, holder.size, MLOCK_ONFAULT),
+  // EXPECT_THAT(LIBC_NAMESPACE::mlock2(holder.addr, holder.size,
+  // MLOCK_ONFAULT),
   //             Succeeds());
   // EXPECT_THAT(LIBC_NAMESPACE::mincore(holder.addr, holder.size, &vec),
   //             Succeeds());
diff --git a/libc/test/src/sys/mman/linux/posix_madvise_test.cpp b/libc/test/src/sys/mman/linux/posix_madvise_test.cpp
index e2f296c44a..03b9d86b40 100644
--- a/libc/test/src/sys/mman/linux/posix_madvise_test.cpp
+++ b/libc/test/src/sys/mman/linux/posix_madvise_test.cpp
@@ -46,5 +46,5 @@ TEST(LlvmLibcPosixMadviseTest, Error_BadPtr) {
   // posix_madvise doesn't set errno, but the return value is actually the error
   // code.
   // EXPECT_EQ(LIBC_NAMESPACE::posix_madvise(nullptr, 8, POSIX_MADV_SEQUENTIAL),
-            // ENOMEM);
+  // ENOMEM);
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/106128


More information about the libc-commits mailing list