[libc-commits] [libc] [libc] Fix unit test compile flags propagation. (PR #106128)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Aug 26 13:21:09 PDT 2024


================
@@ -233,7 +233,7 @@ endfunction()
 
 function(_get_hermetic_test_compile_options output_var flags)
   _get_compile_options_from_flags(compile_flags ${flags})
-  list(APPEND compile_options ${LIBC_COMPILE_OPTIONS_DEFAULT} ${compile_flags}
+  set(compile_options ${LIBC_COMPILE_OPTIONS_DEFAULT} ${compile_flags}
----------------
jhuber6 wrote:

Isn't this just overwriting the flags from `_get_compile_options_from_flags`?

https://github.com/llvm/llvm-project/pull/106128


More information about the libc-commits mailing list