[libc-commits] [libc] [libc] Add `scanf` support to the GPU build (PR #104812)

Wed Aug 21 16:12:48 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `libc` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/4207

Here is the relevant piece of the build log for the reference:
```
Step 5 (compile-openmp) failure: build (failure)
...
3.239 [97/34/523] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.setpayloadf16.dir/setpayloadf16.cpp.o
3.240 [96/34/524] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.setpayloadsigl.dir/setpayloadsigl.cpp.o
3.269 [95/34/525] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.setpayloadsigf16.dir/setpayloadsigf16.cpp.o
3.271 [94/34/526] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.setpayloadsigf.dir/setpayloadsigf.cpp.o
3.386 [93/34/527] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.cbrtf.dir/cbrtf.cpp.o
3.399 [92/34/528] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.sprintf.dir/sprintf.cpp.o
3.422 [91/34/529] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.snprintf.dir/snprintf.cpp.o
3.445 [90/34/530] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.vsprintf.dir/vsprintf.cpp.o
3.453 [89/34/531] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.cbrt.dir/cbrt.cpp.o
3.455 [88/34/532] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.scanf.dir/scanf.cpp.o
FAILED: libc/src/stdio/CMakeFiles/libc.src.stdio.scanf.dir/scanf.cpp.o 
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc -isystem /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -DLIBC_COPT_STDIO_USE_SYSTEM_FILE -DLIBC_COPT_SCANF_DISABLE_FLOAT -DLIBC_COPT_SCANF_DISABLE_INDEX_MODE -MD -MT libc/src/stdio/CMakeFiles/libc.src.stdio.scanf.dir/scanf.cpp.o -MF libc/src/stdio/CMakeFiles/libc.src.stdio.scanf.dir/scanf.cpp.o.d -o libc/src/stdio/CMakeFiles/libc.src.stdio.scanf.dir/scanf.cpp.o -c /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/stdio/scanf.cpp
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/stdio/scanf.cpp:35:34: error: no member named 'stdin' in the global namespace; did you mean simply 'stdin'?
   35 |       reinterpret_cast<::FILE *>(SCANF_STDIN), format, args);
      |                                  ^~~~~~~~~~~
      |                                  stdin
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/stdio/scanf.cpp:22:21: note: expanded from macro 'SCANF_STDIN'
   22 | #define SCANF_STDIN ::stdin
      |                     ^~
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/File/file.h:314:14: note: 'stdin' declared here
  314 | extern File *stdin;
      |              ^
1 error generated.
3.470 [88/33/533] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16add.dir/f16add.cpp.o
3.473 [88/32/534] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.fscanf.dir/fscanf.cpp.o
3.482 [88/31/535] Building CXX object libc/src/stdio/CMakeFiles/libc.src.stdio.vsnprintf.dir/vsnprintf.cpp.o
3.491 [88/30/536] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16addf.dir/f16addf.cpp.o
3.501 [88/29/537] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16subf.dir/f16subf.cpp.o
3.509 [88/28/538] Building CXX object libc/src/stdlib/CMakeFiles/libc.src.stdlib.getenv.dir/getenv.cpp.o
3.522 [88/27/539] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16sqrtl.dir/f16sqrtl.cpp.o
3.524 [88/26/540] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16addl.dir/f16addl.cpp.o
3.524 [88/25/541] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.fsqrt.dir/fsqrt.cpp.o
3.531 [88/24/542] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.fsqrtl.dir/fsqrtl.cpp.o
3.533 [88/23/543] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16div.dir/f16div.cpp.o
3.546 [88/22/544] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16sub.dir/f16sub.cpp.o
3.550 [88/21/545] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16sqrtf.dir/f16sqrtf.cpp.o
3.550 [88/20/546] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16sqrt.dir/f16sqrt.cpp.o
3.556 [88/19/547] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16divf.dir/f16divf.cpp.o
3.558 [88/18/548] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16divl.dir/f16divl.cpp.o
3.565 [88/17/549] Building CXX object libc/src/stdlib/CMakeFiles/libc.src.stdlib.atol.dir/atol.cpp.o
3.569 [88/16/550] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16subl.dir/f16subl.cpp.o
3.579 [88/15/551] Building CXX object libc/src/stdlib/CMakeFiles/libc.src.stdlib.atoll.dir/atoll.cpp.o
3.593 [88/14/552] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16fmaf.dir/f16fmaf.cpp.o
3.594 [88/13/553] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.dmull.dir/dmull.cpp.o
3.597 [88/12/554] Building CXX object libc/src/stdlib/CMakeFiles/libc.src.stdlib.quick_exit.dir/quick_exit.cpp.o
3.602 [88/11/555] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16mulf.dir/f16mulf.cpp.o
3.609 [88/10/556] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16mull.dir/f16mull.cpp.o
3.625 [88/9/557] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16mul.dir/f16mul.cpp.o
3.642 [88/8/558] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.f16fmal.dir/f16fmal.cpp.o

```

https://github.com/llvm/llvm-project/pull/104812