[libc-commits] [libc] [libc] Fix generated header definitions in cmake (PR #104628)
via libc-commits
libc-commits at lists.llvm.org
Fri Aug 16 11:39:35 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Michael Jones (michaelrj-google)
<details>
<summary>Changes</summary>
Some new headers were not being properly built with
new headergen, since they were using the old "add_gen_header" instead of
the new "add_header_macro". This patch fixes the issue.
---
Full diff: https://github.com/llvm/llvm-project/pull/104628.diff
1 Files Affected:
- (modified) libc/include/CMakeLists.txt (+8-6)
``````````diff
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 2b6eb61782a632..4e3ae7f801f4a0 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -420,19 +420,21 @@ add_header_macro(
.llvm-libc-types.posix_spawn_file_actions_t
)
-add_gen_header(
+add_header_macro(
link
- DEF_FILE link.h.def
- GEN_HDR link.h
+ ../libc/newhdrgen/yaml/link.yaml
+ link.h.def
+ link.h
DEPENDS
.llvm_libc_common_h
.llvm-libc-macros.link_macros
)
-add_gen_header(
+add_header_macro(
elf
- DEF_FILE elf.h.def
- GEN_HDR elf.h
+ ../libc/newhdrgen/yaml/elf.yaml
+ elf.h.def
+ elf.h
DEPENDS
.llvm-libc-macros.elf_macros
)
``````````
</details>
https://github.com/llvm/llvm-project/pull/104628
More information about the libc-commits
mailing list