[libc-commits] [libc] [libc][math] Fix missing const in hdrgen signatures for totalordermag* (PR #103935)
via libc-commits
libc-commits at lists.llvm.org
Wed Aug 14 06:20:24 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: OverMighty (overmighty)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/103935.diff
2 Files Affected:
- (modified) libc/newhdrgen/yaml/math.yaml (+10-10)
- (modified) libc/spec/stdc.td (+5-5)
``````````diff
diff --git a/libc/newhdrgen/yaml/math.yaml b/libc/newhdrgen/yaml/math.yaml
index a244a307a206f..b4ee7f539c2cf 100644
--- a/libc/newhdrgen/yaml/math.yaml
+++ b/libc/newhdrgen/yaml/math.yaml
@@ -2361,37 +2361,37 @@ functions:
- stdc
return_type: int
arguments:
- - type: double *
- - type: double *
+ - type: const double *
+ - type: const double *
- name: totalordermagf
standards:
- stdc
return_type: int
arguments:
- - type: float *
- - type: float *
+ - type: const float *
+ - type: const float *
- name: totalordermagl
standards:
- stdc
return_type: int
arguments:
- - type: long double *
- - type: long double *
+ - type: const long double *
+ - type: const long double *
- name: totalordermagf128
standards:
- stdc
return_type: int
arguments:
- - type: float128 *
- - type: float128 *
+ - type: const float128 *
+ - type: const float128 *
guard: LIBC_TYPES_HAS_FLOAT128
- name: totalordermagf16
standards:
- stdc
return_type: int
arguments:
- - type: _Float16 *
- - type: _Float16 *
+ - type: const _Float16 *
+ - type: const _Float16 *
guard: LIBC_TYPES_HAS_FLOAT16
- name: trunc
standards:
diff --git a/libc/spec/stdc.td b/libc/spec/stdc.td
index 74afb60725b7f..8497acbfd62f0 100644
--- a/libc/spec/stdc.td
+++ b/libc/spec/stdc.td
@@ -752,11 +752,11 @@ def StdC : StandardSpec<"stdc"> {
GuardedFunctionSpec<"totalorderf16", RetValSpec<IntType>, [ArgSpec<ConstFloat16Ptr>, ArgSpec<ConstFloat16Ptr>], "LIBC_TYPES_HAS_FLOAT16">,
GuardedFunctionSpec<"totalorderf128", RetValSpec<IntType>, [ArgSpec<ConstFloat128Ptr>, ArgSpec<ConstFloat128Ptr>], "LIBC_TYPES_HAS_FLOAT128">,
- FunctionSpec<"totalordermag", RetValSpec<IntType>, [ArgSpec<DoublePtr>, ArgSpec<DoublePtr>]>,
- FunctionSpec<"totalordermagf", RetValSpec<IntType>, [ArgSpec<FloatPtr>, ArgSpec<FloatPtr>]>,
- FunctionSpec<"totalordermagl", RetValSpec<IntType>, [ArgSpec<LongDoublePtr>, ArgSpec<LongDoublePtr>]>,
- GuardedFunctionSpec<"totalordermagf16", RetValSpec<IntType>, [ArgSpec<Float16Ptr>, ArgSpec<Float16Ptr>], "LIBC_TYPES_HAS_FLOAT16">,
- GuardedFunctionSpec<"totalordermagf128", RetValSpec<IntType>, [ArgSpec<Float128Ptr>, ArgSpec<Float128Ptr>], "LIBC_TYPES_HAS_FLOAT128">,
+ FunctionSpec<"totalordermag", RetValSpec<IntType>, [ArgSpec<ConstDoublePtr>, ArgSpec<ConstDoublePtr>]>,
+ FunctionSpec<"totalordermagf", RetValSpec<IntType>, [ArgSpec<ConstFloatPtr>, ArgSpec<ConstFloatPtr>]>,
+ FunctionSpec<"totalordermagl", RetValSpec<IntType>, [ArgSpec<ConstLongDoublePtr>, ArgSpec<ConstLongDoublePtr>]>,
+ GuardedFunctionSpec<"totalordermagf16", RetValSpec<IntType>, [ArgSpec<ConstFloat16Ptr>, ArgSpec<ConstFloat16Ptr>], "LIBC_TYPES_HAS_FLOAT16">,
+ GuardedFunctionSpec<"totalordermagf128", RetValSpec<IntType>, [ArgSpec<ConstFloat128Ptr>, ArgSpec<ConstFloat128Ptr>], "LIBC_TYPES_HAS_FLOAT128">,
FunctionSpec<"getpayload", RetValSpec<DoubleType>, [ArgSpec<DoublePtr>]>,
FunctionSpec<"getpayloadf", RetValSpec<FloatType>, [ArgSpec<FloatPtr>]>,
``````````
</details>
https://github.com/llvm/llvm-project/pull/103935
More information about the libc-commits
mailing list