[libc-commits] [libc] libc: Remove `extern "C"` from main declarations (PR #102825)

Sun Aug 11 13:19:49 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-fullbuild-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/4073

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[8/99] Building CXX object projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_name_test.__build__.dir/pthread_name_test.cpp.o
[9/99] Building CXX object projects/libc/test/integration/startup/linux/CMakeFiles/libc.test.integration.startup.linux.startup_no_args_test.__build__.dir/main_without_args.cpp.o
[10/99] Building CXX object projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_mutex_test.__build__.dir/pthread_mutex_test.cpp.o
[11/99] Building CXX object projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_equal_test.__build__.dir/pthread_equal_test.cpp.o
[12/99] Building CXX object projects/libc/test/integration/startup/linux/CMakeFiles/libc.test.integration.startup.linux.startup_no_envp_test.__build__.dir/main_without_envp.cpp.o
[13/99] Building CXX object projects/libc/test/integration/startup/linux/CMakeFiles/libc.test.integration.startup.linux.init_fini_array_test.__build__.dir/init_fini_array_test.cpp.o
[14/99] Building CXX object projects/libc/test/integration/src/__support/threads/CMakeFiles/libc.test.integration.src.__support.threads.thread_tls_test.__build__.dir/thread_tls_test.cpp.o
[15/99] Linking CXX executable projects/libc/test/integration/startup/linux/libc.test.integration.startup.linux.startup_args_test.__build__
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
[16/99] Linking CXX executable projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_join_test.__build__
FAILED: projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_join_test.__build__ 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -nolibc -nostartfiles -nostdlib++ -static projects/libc/startup/linux/crt1.o projects/libc/test/IntegrationTest/CMakeFiles/libc.test.IntegrationTest.test.dir/test.cpp.o projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_join_test.__build__.dir/pthread_join_test.cpp.o -o projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_join_test.__build__  projects/libc/test/integration/src/pthread/liblibc.test.integration.src.pthread.pthread_join_test.libc.a && :
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
/usr/bin/ld: projects/libc/startup/linux/crt1.o: in function `__llvm_libc_19_0_0_git::do_start()':
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/startup/linux/do_start.cpp:147: undefined reference to `main(int, char**, char**)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[17/99] Linking CXX executable projects/libc/test/integration/startup/linux/libc.test.integration.startup.linux.startup_tls_test.__build__
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
[18/99] Building CXX object projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_once_test.__build__.dir/pthread_once_test.cpp.o
[19/99] Linking CXX executable projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_test.__build__
FAILED: projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_test.__build__ 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -nolibc -nostartfiles -nostdlib++ -static projects/libc/startup/linux/crt1.o projects/libc/test/IntegrationTest/CMakeFiles/libc.test.IntegrationTest.test.dir/test.cpp.o projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_test.__build__.dir/pthread_test.cpp.o -o projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_test.__build__  projects/libc/test/integration/src/pthread/liblibc.test.integration.src.pthread.pthread_test.libc.a && :
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
/usr/bin/ld: projects/libc/startup/linux/crt1.o: in function `__llvm_libc_19_0_0_git::do_start()':
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/startup/linux/do_start.cpp:147: undefined reference to `main(int, char**, char**)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[20/99] Linking CXX executable projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_spinlock_test.__build__
FAILED: projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_spinlock_test.__build__ 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -nolibc -nostartfiles -nostdlib++ -static projects/libc/startup/linux/crt1.o projects/libc/test/IntegrationTest/CMakeFiles/libc.test.IntegrationTest.test.dir/test.cpp.o projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_spinlock_test.__build__.dir/pthread_spinlock_test.cpp.o -o projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_spinlock_test.__build__  projects/libc/test/integration/src/pthread/liblibc.test.integration.src.pthread.pthread_spinlock_test.libc.a && :
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
/usr/bin/ld: projects/libc/startup/linux/crt1.o: in function `__llvm_libc_19_0_0_git::do_start()':
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/startup/linux/do_start.cpp:147: undefined reference to `main(int, char**, char**)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[21/99] Running integration test libc.test.integration.startup.linux.startup_args_test
[22/99] Linking CXX executable projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_exit_test.__build__
FAILED: projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_exit_test.__build__ 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -nolibc -nostartfiles -nostdlib++ -static projects/libc/startup/linux/crt1.o projects/libc/test/IntegrationTest/CMakeFiles/libc.test.IntegrationTest.test.dir/test.cpp.o projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_exit_test.__build__.dir/pthread_exit_test.cpp.o -o projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_exit_test.__build__  projects/libc/test/integration/src/pthread/liblibc.test.integration.src.pthread.pthread_exit_test.libc.a && :
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
/usr/bin/ld: projects/libc/startup/linux/crt1.o: in function `__llvm_libc_19_0_0_git::do_start()':
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/startup/linux/do_start.cpp:147: undefined reference to `main(int, char**, char**)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[23/99] Linking CXX executable projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_tss_test.__build__
FAILED: projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_tss_test.__build__ 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -nolibc -nostartfiles -nostdlib++ -static projects/libc/startup/linux/crt1.o projects/libc/test/IntegrationTest/CMakeFiles/libc.test.IntegrationTest.test.dir/test.cpp.o projects/libc/test/integration/src/pthread/CMakeFiles/libc.test.integration.src.pthread.pthread_tss_test.__build__.dir/pthread_tss_test.cpp.o -o projects/libc/test/integration/src/pthread/libc.test.integration.src.pthread.pthread_tss_test.__build__  projects/libc/test/integration/src/pthread/liblibc.test.integration.src.pthread.pthread_tss_test.libc.a && :
/usr/bin/ld: warning: cannot create .note.gnu.build-id section, --build-id ignored
/usr/bin/ld: projects/libc/startup/linux/crt1.o: in function `__llvm_libc_19_0_0_git::do_start()':
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/startup/linux/do_start.cpp:147: undefined reference to `main(int, char**, char**)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[24/99] Linking CXX executable projects/libc/test/integration/startup/linux/libc.test.integration.startup.linux.startup_no_args_test.__build__

```

https://github.com/llvm/llvm-project/pull/102825