[libc-commits] [libc] [libc][math][c23] Add fadd{l, f128} C23 math functions (PR #102531)

via libc-commits libc-commits at lists.llvm.org
Thu Aug 8 16:24:02 PDT 2024


================
@@ -408,6 +408,7 @@ def StdC : StandardSpec<"stdc"> {
           GuardedFunctionSpec<"fabsf16", RetValSpec<Float16Type>, [ArgSpec<Float16Type>], "LIBC_TYPES_HAS_FLOAT16">,
           GuardedFunctionSpec<"fabsf128", RetValSpec<Float128Type>, [ArgSpec<Float128Type>], "LIBC_TYPES_HAS_FLOAT128">,
           FunctionSpec<"fadd", RetValSpec<FloatType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
+          FunctionSpec<"faddl", RetValSpec<FloatType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>,
----------------
overmighty wrote:

Nit: should have a blank line to separate `fabs*` from `fadd*`.

```suggestion
          GuardedFunctionSpec<"fabsf128", RetValSpec<Float128Type>, [ArgSpec<Float128Type>], "LIBC_TYPES_HAS_FLOAT128">,

          FunctionSpec<"fadd", RetValSpec<FloatType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
          FunctionSpec<"faddl", RetValSpec<FloatType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>,
```

https://github.com/llvm/llvm-project/pull/102531


More information about the libc-commits mailing list