[libc-commits] [libc] [libc][math][c23] Add ddivl C23 math function. (PR #102468)

via libc-commits libc-commits at lists.llvm.org
Thu Aug 8 08:10:14 PDT 2024


================
@@ -47,7 +47,7 @@ class DivTest : public LIBC_NAMESPACE::testing::FEnvSafeTest {
       InType x = InFPBits(v).get_val();
       InType y = InFPBits(w).get_val();
       mpfr::BinaryInput<InType> input{x, y};
-      EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Div, input, func(x, y),
+      ASSERT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Div, input, func(x, y),
                                      0.5);
----------------
overmighty wrote:

Isn't it better to have the test print all failures? My understanding was that `ASSERT_*` should be used if failure could prevent the rest of the test code from working as expected.

https://github.com/llvm/llvm-project/pull/102468


More information about the libc-commits mailing list