[libc-commits] [libc] [libc] Use proxy headers for `limits.h` values (PR #102378)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Wed Aug 7 14:55:26 PDT 2024


https://github.com/michaelrj-google approved this pull request.

Overall LGTM but also remember to update the cmake and the bazel. Here's the diff that fixes the bazel:
``` diff
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 253b89216a88..e52bf2782638 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -150,6 +150,12 @@ libc_support_library(
     hdrs = ["hdr/stdio_macros.h"],
 )
 
+
+libc_support_library(
+    name = "hdr_limits_macros",
+    hdrs = ["hdr/limits_macros.h"],
+)
+
 ############################ Type Proxy Header Files ###########################
 
 libc_support_library(
@@ -362,7 +368,7 @@ libc_support_library(
         "__support_cpp_type_traits",
         "__support_macros_attributes",
         ":__support_macros_properties_types",
-        ":llvm_libc_macros_limits_macros",
+        ":hdr_limits_macros",
     ],
 )
```

https://github.com/llvm/llvm-project/pull/102378


More information about the libc-commits mailing list