[libc-commits] [libc] [libc] Make use of 32-bit time_t a config option (PR #102012)

via libc-commits libc-commits at lists.llvm.org
Tue Aug 6 04:47:54 PDT 2024


lntue wrote:

I agree about the danger of modifying files in the source tree with build actions.  In that case, I think the following would solve our problems:
- Copy either `time_t_32.h` or `time_t_64.h` to public include `time_t.h` as in your current change.
- Keep the current `libc/include/llvm-libc-types/time_t.h`, adding the condition `&& !defined(LIBC_TYPES_TIME_T_64_BIT)` in addition to current arm target detection.
- Add `-DLIBC_TYPES_TIME_T_64_BIT` to common object and test options in full build mode if `LIBC_CONF_TIME_64BIT` is on.
WDYT?

https://github.com/llvm/llvm-project/pull/102012


More information about the libc-commits mailing list