[libc-commits] [libc] [libc] add simplified tid cache (PR #101620)

Fri Aug 2 11:44:36 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `libc` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/4969

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
6.832 [763/58/620] Building CXX object libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.vfprintf.dir/vfprintf.cpp.o
6.833 [762/58/621] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o
6.834 [761/58/622] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strlen.dir/strlen.cpp.o
6.835 [760/58/623] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strrchr.dir/strrchr.cpp.o
6.835 [759/58/624] Building CXX object libc/src/termios/linux/CMakeFiles/libc.src.termios.linux.tcdrain.dir/tcdrain.cpp.o
6.836 [758/58/625] Building CXX object libc/src/termios/linux/CMakeFiles/libc.src.termios.linux.tcflow.dir/tcflow.cpp.o
6.838 [757/58/626] Building CXX object libc/src/termios/linux/CMakeFiles/libc.src.termios.linux.tcsendbreak.dir/tcsendbreak.cpp.o
6.841 [756/58/627] Building CXX object libc/src/termios/linux/CMakeFiles/libc.src.termios.linux.tcsetattr.dir/tcsetattr.cpp.o
6.842 [755/58/628] Building CXX object libc/src/termios/linux/CMakeFiles/libc.src.termios.linux.tcgetattr.dir/tcgetattr.cpp.o
6.850 [754/58/629] Building CXX object libc/src/unistd/CMakeFiles/libc.src.unistd.gettid.dir/gettid.cpp.o
FAILED: libc/src/unistd/CMakeFiles/libc.src.unistd.gettid.dir/gettid.cpp.o 
/build/buildbot/premerge-monolithic-linux/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/build/buildbot/premerge-monolithic-linux/llvm-project/libc -isystem /build/buildbot/premerge-monolithic-linux/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -fpie -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -std=gnu++17 -MD -MT libc/src/unistd/CMakeFiles/libc.src.unistd.gettid.dir/gettid.cpp.o -MF libc/src/unistd/CMakeFiles/libc.src.unistd.gettid.dir/gettid.cpp.o.d -o libc/src/unistd/CMakeFiles/libc.src.unistd.gettid.dir/gettid.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/unistd/gettid.cpp
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/unistd/gettid.cpp:11:
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/threads/identifier.h:35:7: error: use of undeclared identifier 'LIBC_UNLIKELY'
   35 |   if (LIBC_UNLIKELY(!cache || *cache <= 0))
      |       ^
1 error generated.
6.851 [754/57/630] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.access.dir/access.cpp.o
6.851 [754/56/631] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strndup.dir/strndup.cpp.o
6.851 [754/55/632] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strsep.dir/strsep.cpp.o
6.852 [754/54/633] Building CXX object libc/src/string/CMakeFiles/libc.src.string.bzero.dir/bzero.cpp.o
6.860 [754/53/634] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.close.dir/close.cpp.o
6.863 [754/52/635] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strlcpy.dir/strlcpy.cpp.o
6.867 [754/51/636] Building CXX object libc/src/string/CMakeFiles/libc.src.string.memcpy.dir/memcpy.cpp.o
6.869 [754/50/637] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.dup.dir/dup.cpp.o
6.871 [754/49/638] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.chdir.dir/chdir.cpp.o
6.872 [754/48/639] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strtok.dir/strtok.cpp.o
6.875 [754/47/640] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.fsync.dir/fsync.cpp.o
6.877 [754/46/641] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.fchdir.dir/fchdir.cpp.o
6.881 [754/45/642] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o
6.882 [754/44/643] Building CXX object libc/src/string/CMakeFiles/libc.src.string.stpncpy.dir/stpncpy.cpp.o
6.882 [754/43/644] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.geteuid.dir/geteuid.cpp.o
6.883 [754/42/645] Building CXX object libc/src/string/CMakeFiles/libc.src.string.bcmp.dir/bcmp.cpp.o
6.884 [754/41/646] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.dup2.dir/dup2.cpp.o
6.885 [754/40/647] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strpbrk.dir/strpbrk.cpp.o
6.886 [754/39/648] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.fpathconf.dir/fpathconf.cpp.o
6.886 [754/38/649] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strxfrm.dir/strxfrm.cpp.o
6.888 [754/37/650] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.execve.dir/execve.cpp.o
6.890 [754/36/651] Building CXX object libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.printf.dir/printf.cpp.o
6.891 [754/35/652] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.getppid.dir/getppid.cpp.o
6.891 [754/34/653] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.getpid.dir/getpid.cpp.o
6.898 [754/33/654] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.getuid.dir/getuid.cpp.o
6.898 [754/32/655] Building CXX object libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.fprintf.dir/fprintf.cpp.o
6.903 [754/31/656] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strtok_r.dir/strtok_r.cpp.o
6.904 [754/30/657] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.dup3.dir/dup3.cpp.o
6.906 [754/29/658] Building CXX object libc/src/stdio/generic/CMakeFiles/libc.src.stdio.generic.vprintf.dir/vprintf.cpp.o
6.911 [754/28/659] Building CXX object libc/src/string/CMakeFiles/libc.src.string.memset_explicit.dir/memset_explicit.cpp.o
6.916 [754/27/660] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.ftruncate.dir/ftruncate.cpp.o
6.916 [754/26/661] Building CXX object libc/src/unistd/linux/CMakeFiles/libc.src.unistd.linux.linkat.dir/linkat.cpp.o

```

https://github.com/llvm/llvm-project/pull/101620